starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Enhancement] Complete the error message when selecting an Iceberg table created by spark2

Open mxdzs0612 opened this issue 2 years ago • 3 comments

What type of PR is this:

  • [ ] bug
  • [ ] feature
  • [x] enhancement
  • [ ] refactor
  • [ ] others

Which issues of this PR fixes :

Fixes #

Problem Summary(Required) :

Iceberg tables created with spark2 by default configurations doesn't have the property 'metadata_location', which is necessary when selected using Hive catalog. Trino also cannot select such table, so I suppose it reasonable and just throw an exception with reasons in detail.

MySQL client will crash when executing show tables after using a database with such tables. I'll try to solve it later in a separated PR.

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] I have added user document for my new feature or new function

mxdzs0612 avatar Aug 12 '22 07:08 mxdzs0612

@caneGuy @stephen-shelby PTAL

mxdzs0612 avatar Aug 12 '22 07:08 mxdzs0612

run starrocks_fe_unittest

mxdzs0612 avatar Aug 12 '22 08:08 mxdzs0612

run starrocks_fe_unittest

mxdzs0612 avatar Aug 15 '22 01:08 mxdzs0612

[FE PR Coverage Check]

:disappointed: fail : 0 / 2 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/external/iceberg/hive/HiveTableOperations.java 0 2 00.00% [82, 83]

wanpengfei-git avatar Aug 15 '22 01:08 wanpengfei-git

run starrocks_admit_test

wanpengfei-git avatar Aug 17 '22 06:08 wanpengfei-git

@Mergifyio backport branch-2.4

mxdzs0612 avatar Aug 17 '22 08:08 mxdzs0612

backport branch-2.4

✅ Backports have been created

mergify[bot] avatar Aug 17 '22 08:08 mergify[bot]