starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Enhancement] Upgrade lib for Apache Hadoop argument injection vulnerability

Open Astralidea opened this issue 3 years ago • 3 comments

What type of PR is this:

  • [ ] bug
  • [ ] feature
  • [x] enhancement
  • [ ] refactor
  • [ ] others

Which issues of this PR fixes :

Fixes #

Problem Summary(Required) :

more detail in CVE-2022-25168.

Apache Hadoop's FileUtil.unTar(File, File) API does not escape the input file name before being passed to the shell. An attacker can inject arbitrary commands. This is only used in Hadoop 3.3 InMemoryAliasMap.completeBootstrapTransfer, which is only ever run by a local user. It has been used in Hadoop 2.x for yarn localization, which does enable remote code execution. It is used in Apache Spark, from the SQL command ADD ARCHIVE. As the ADD ARCHIVE command adds new binaries to the classpath, being able to execute shell scripts does not confer new permissions to the caller. SPARK-38305. "Check existence of file before untarring/zipping", which is included in 3.3.0, 3.1.4, 3.2.2, prevents shell commands being executed, regardless of which version of the hadoop libraries are in use. Users should upgrade to Apache Hadoop 2.10.2, 3.2.4, 3.3.3 or upper (including HADOOP-18136).

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] I have added user document for my new feature or new function

Astralidea avatar Aug 12 '22 07:08 Astralidea

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Aug 12 '22 07:08 sonarqubecloud[bot]

[FE PR Coverage Check]

:heart_eyes: pass : 0 / 0 (0%)

wanpengfei-git avatar Aug 12 '22 07:08 wanpengfei-git

run starrocks_admit_test

Astralidea avatar Aug 12 '22 07:08 Astralidea