starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Bugfix] Support create mv select data from different internal database

Open Astralidea opened this issue 3 years ago • 1 comments

What type of PR is this:

  • [x] bug
  • [ ] feature
  • [ ] enhancement
  • [ ] refactor
  • [ ] others

Which issues of this PR fixes :

Fixes #9792

Problem Summary(Required) :

add new meta @SerializedName(value = "baseTableInfos") used to record dbId information.Then use baseDb to do it at different times of checking and using.

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] I have added user document for my new feature or new function

Astralidea avatar Aug 12 '22 07:08 Astralidea

run starrocks_fe_unittest

Astralidea avatar Aug 15 '22 08:08 Astralidea

run starrocks_admit_test

Astralidea avatar Aug 15 '22 08:08 Astralidea

run starrocks_admit_test

Astralidea avatar Aug 15 '22 09:08 Astralidea

[FE PR Coverage Check]

:heart_eyes: pass : 103 / 127 (81.10%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/catalog/MaterializedView.java 10 21 47.62% [248, 342, 347, 348, 349, 354, 355, 356, 357, 362, 363]
:large_blue_circle: com/starrocks/scheduler/PartitionBasedMaterializedViewRefreshProcessor.java 49 58 84.48% [447, 455, 511, 512, 516, 517, 518, 525, 530]
:large_blue_circle: com/starrocks/catalog/BaseTableInfo.java 12 14 85.71% [26, 27]
:large_blue_circle: com/starrocks/server/LocalMetastore.java 8 9 88.89% [3340]
:large_blue_circle: com/starrocks/sql/analyzer/MaterializedViewAnalyzer.java 22 23 95.65% [154]
:large_blue_circle: com/starrocks/sql/ast/CreateMaterializedViewStatement.java 2 2 100.00% []

wanpengfei-git avatar Sep 05 '22 03:09 wanpengfei-git

This close because we have a better solution in #11131

Astralidea avatar Sep 13 '22 12:09 Astralidea