starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard
verified publisher icon StarRocks

[SR SQL Planner Summer Camp]Refact admin repair table

Open amorynan opened this issue 3 years ago • 5 comments

What type of PR is this：

  • [ ] bug
  • [ ] feature
  • [ ] enhancement
  • [x] refactor
  • [ ] others

Which issues of this PR fixes ：

Fixes #7945

Problem Summary(Required) ：

support admin repair table and so on statement

Checklist:

  • [x] I have added test cases for my bug fix or my new feature
  • [x] I have added user document for my new feature or new function

amorynan avatar Aug 11 '22 02:08 amorynan

run starrocks_fe_unittest

amorynan avatar Aug 11 '22 13:08 amorynan

@imay @HangyuanLiu please review to this pr

amorynan avatar Aug 12 '22 02:08 amorynan

run starrocks_fe_unittest

amorynan avatar Aug 12 '22 06:08 amorynan

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Aug 16 '22 03:08 sonarqubecloud[bot]

run starrocks_fe_unittest

HangyuanLiu avatar Aug 16 '22 05:08 HangyuanLiu

[FE PR Coverage Check]

:heart_eyes: pass : 89 / 98 (90.82%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/sql/ast/AstVisitor.java 0 3 00.00% [212, 215, 218]
:large_blue_circle: com/starrocks/sql/analyzer/PrivilegeChecker.java 6 9 66.67% [271, 278, 285]
:large_blue_circle: com/starrocks/sql/analyzer/AdminStmtAnalyzer.java 33 36 91.67% [158, 181, 201]
:large_blue_circle: com/starrocks/analysis/AdminRepairTableStmt.java 9 9 100.00% []
:large_blue_circle: com/starrocks/sql/analyzer/Analyzer.java 6 6 100.00% []
:large_blue_circle: com/starrocks/sql/parser/AstBuilder.java 23 23 100.00% []
:large_blue_circle: com/starrocks/analysis/AdminCancelRepairTableStmt.java 7 7 100.00% []
:large_blue_circle: com/starrocks/analysis/AdminCheckTabletsStmt.java 5 5 100.00% []

wanpengfei-git avatar Aug 16 '22 05:08 wanpengfei-git

@imay please review this pr , thx.

amorynan avatar Aug 16 '22 06:08 amorynan

run starrocks_admit_test

wanpengfei-git avatar Aug 16 '22 06:08 wanpengfei-git