starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Feature] DLA jdbc connector for mysql

Open zombee0 opened this issue 2 years ago • 11 comments

Signed-off-by: zombee0 [email protected]

What type of PR is this:

  • [ ] bug
  • [x] feature
  • [ ] enhancement
  • [ ] refactor
  • [ ] others

Which issues of this PR fixes :

Fixes #7271

Problem Summary(Required) :

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] I have added user document for my new feature or new function

zombee0 avatar Aug 07 '22 10:08 zombee0

@zombee0 Many thanks for the contribution. Great Job! Could you take a look on sonarcloud complaining about? It gives some potential modification suggestions image

DorianZheng avatar Aug 08 '22 03:08 DorianZheng

Could add some UT to cover new added methods and classes

DorianZheng avatar Aug 08 '22 03:08 DorianZheng

Could add some UT to cover new added methods and classes

thank you so much, i will do them all

zombee0 avatar Aug 08 '22 11:08 zombee0

run starrocks_fe_unittest

zombee0 avatar Aug 09 '22 12:08 zombee0

run starrocks_fe_unittest

zombee0 avatar Aug 09 '22 13:08 zombee0

run starrocks_fe_unittest

zombee0 avatar Aug 10 '22 12:08 zombee0

run starrocks_fe_unittest

zombee0 avatar Aug 11 '22 14:08 zombee0

run starrocks_fe_unittest

zombee0 avatar Aug 11 '22 14:08 zombee0

[FE PR Coverage Check]

:disappointed: fail : 112 / 193 (58.03%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/connector/jdbc/JDBCConnector.java 17 41 41.46% [55, 56, 57, 59, 60, 61, 63, 64, 65, 67, 68, 70, 71, 72, 73, 74, 75, 79, 81, 82, 83, 84, 85, 87]
:large_blue_circle: com/starrocks/connector/jdbc/JDBCSchemaResolver.java 12 23 52.17% [20, 21, 22, 23, 25, 26, 28, 29, 30, 31, 54]
:large_blue_circle: com/starrocks/connector/jdbc/MysqlSchemaResolver.java 23 42 54.76% [36, 37, 46, 47, 49, 50, 52, 53, 58, 59, 61, 62, 64, 65, 74, 75, 77, 78, 80]
:large_blue_circle: com/starrocks/connector/jdbc/JDBCMetadata.java 29 45 64.44% [35, 36, 37, 42, 43, 58, 59, 69, 71, 72, 87, 88, 98, 101, 102, 103]
:large_blue_circle: com/starrocks/connector/jdbc/JDBCConnectorFactory.java 2 3 66.67% [13]
:large_blue_circle: com/starrocks/catalog/JDBCTable.java 27 37 72.97% [110, 111, 112, 113, 114, 115, 117, 118, 119, 120]
:large_blue_circle: com/starrocks/sql/ast/CreateCatalogStmt.java 1 1 100.00% []
:large_blue_circle: com/starrocks/connector/ConnectorMgr.java 1 1 100.00% []

wanpengfei-git avatar Aug 11 '22 14:08 wanpengfei-git

run starrocks_admit_test

wanpengfei-git avatar Aug 12 '22 06:08 wanpengfei-git