starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[SR SQL Planner Summer Camp] add createRepository analyzer

Open melt-code opened this issue 3 years ago • 7 comments
trafficstars

What type of PR is this:

  • [ ] bug
  • [x] feature
  • [ ] enhancement
  • [ ] refactor
  • [ ] others

Which issues of this PR fixes :

Fixes #7951

Problem Summary(Required) :

add createRepository analyzer

melt-code avatar Jul 20 '22 04:07 melt-code

run starrocks_be_unittest

melt-code avatar Jul 31 '22 00:07 melt-code

run starrocks_fe_unittest

melt-code avatar Jul 31 '22 01:07 melt-code

@melt-code now we support backup and restore supports without broker: https://github.com/StarRocks/starrocks/pull/9319. New createRepository analyzer here should also support this.

xiaoyong-z avatar Aug 10 '22 11:08 xiaoyong-z

Grammar for create repository without broker

image

xiaoyong-z avatar Aug 10 '22 11:08 xiaoyong-z

Grammar for create repository without broker

image

Syntax compatibility for this grammar has been added

melt-code avatar Aug 10 '22 14:08 melt-code

[FE PR Coverage Check]

:heart_eyes: pass : 41 / 48 (85.42%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/sql/ast/AstVisitor.java 0 1 00.00% [453]
:large_blue_circle: com/starrocks/sql/analyzer/PrivilegeChecker.java 2 3 66.67% [1269]
:large_blue_circle: com/starrocks/sql/analyzer/CreateRepositoryAnalyzer.java 23 28 82.14% [15, 30, 47, 48, 53]
:large_blue_circle: com/starrocks/sql/analyzer/Analyzer.java 2 2 100.00% []
:large_blue_circle: com/starrocks/sql/parser/AstBuilder.java 12 12 100.00% []
:large_blue_circle: com/starrocks/analysis/CreateRepositoryStmt.java 2 2 100.00% []

wanpengfei-git avatar Sep 19 '22 15:09 wanpengfei-git

run starrocks_admit_test

melt-code avatar Sep 19 '22 15:09 melt-code

run starrocks_admit_test

wanpengfei-git avatar Sep 20 '22 02:09 wanpengfei-git