starrocks
starrocks copied to clipboard
[BugFix] generate statistics for empty iceberg table
What type of PR is this:
- [x] bug
- [ ] feature
- [ ] enhancement
- [ ] refactor
- [ ] others
Which issues of this PR fixes :
Fixes #6840
Problem Summary(Required) :
return statistics for empty iceberg table, and record is zero.
@DorianZheng , plz review it.
I want to add ut, maybe add in generate optimizedPlan, but how to contruct iceberg table.
@hongli-my you can rerun the job just left a message like "run starrocks_fe_unittest", then the job will run atomaticly
[FE PR Coverage check]
:disappointed: fail : 0 / 17 (00.00%)
file detail
path | covered line | new line | coverage | |
---|---|---|---|---|
:large_blue_circle: | com/starrocks/external/iceberg/cost/IcebergTableStatisticCalculator.java | 0 | 17 | 00.00% |
run starrocks_fe_unittest
run starrocks_fe_unittest
plz add ut
done, I mock currentSnapshot function to return null to generate IcebergFileStats
[FE PR Coverage Check]
:disappointed: fail : 1 / 17 (05.88%)
file detail
path | covered_line | new_line | coverage | not_covered_line_detail | |
---|---|---|---|---|---|
:large_blue_circle: | com/starrocks/external/iceberg/cost/IcebergTableStatisticCalculator.java | 1 | 17 | 05.88% | [70, 71, 72, 74, 75, 76, 77, 78, 79, 80, 81, 84, 85, 86, 225, 226] |
run starrocks_admit_test
run starrocks_admit_test
@Mergifyio backport branch-2.4
backport branch-2.4
✅ Backports have been created
-
#11352 [BugFix] generate statistics for empty iceberg table (backport #6846) has been created for branch
branch-2.4