[BugFix] fix json length check
Why I'm doing:
What I'm doing:
Minimal length is 1024, which should be allowed.
Fixes #https://github.com/StarRocks/StarRocksTest/issues/10673
What type of PR is this:
- [x] BugFix
- [ ] Feature
- [ ] Enhancement
- [ ] Refactor
- [ ] UT
- [ ] Doc
- [ ] Tool
Does this PR entail a change in behavior?
- [ ] Yes, this PR will result in a change in behavior.
- [x] No, this PR will not result in a change in behavior.
If yes, please specify the type of change:
- [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
- [ ] Parameter changes: default values, similar parameters but with different default values
- [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
- [ ] Feature removed
- [ ] Miscellaneous: upgrade & downgrade compatibility, etc.
Checklist:
- [ ] I have added test cases for my bug fix or my new feature
- [ ] This pr needs user documentation (for new or modified features or behaviors)
- [ ] I have added documentation for my new feature or new function
- [ ] This is a backport pr
Bugfix cherry-pick branch check:
- [x] I have checked the version labels which the pr will be auto-backported to the target branch
- [x] 4.0
- [x] 3.5
- [ ] 3.4
- [ ] 3.3
[!NOTE] Permits schema change from JSON to CHAR/VARCHAR when target length equals the JSON minimum (e.g., 1024).
- Catalog
- In
Column.checkSchemaChangeAllowed, relax JSON length check: change<=to<so converting JSON toCHAR/VARCHARis allowed when targetstrLenequalsPrimitiveType.JSON.getTypeSize().Written by Cursor Bugbot for commit b81f3cd8a17459f13180465dde20dd4f2ea6c380. This will update automatically on new commits. Configure here.
๐งช CI Insights
Here's what we observed from your CI run for b81f3cd8.
๐ข All jobs passed!
But CI Insights is watching ๐
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
@cursor review
[Java-Extensions Incremental Coverage Report]
:white_check_mark: pass : 0 / 0 (0%)
[BE Incremental Coverage Report]
:white_check_mark: pass : 0 / 0 (0%)
[FE Incremental Coverage Report]
:white_check_mark: pass : 1 / 1 (100.00%)
file detail
| path | covered_line | new_line | coverage | not_covered_line_detail | |
|---|---|---|---|---|---|
| :large_blue_circle: | com/starrocks/catalog/Column.java | 1 | 1 | 100.00% | [] |
@Mergifyio backport branch-3.5
@Mergifyio backport branch-4.0
backport branch-3.5
โ Backports have been created
- #66706 [BugFix] fix json length check (backport #66628) has been created for branch
branch-3.5
backport branch-4.0
โ Backports have been created
- #66707 [BugFix] fix json length check (backport #66628) has been created for branch
branch-4.0