starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Enhancement]Display the index of the blacklist rule matched for a forbidden SQL

Open zhaohehuhu opened this issue 2 weeks ago β€’ 7 comments

Why I'm doing:

It’s a bit easy for the admin to track which blacklist rule matches a given SQL

What I'm doing:

as title

What type of PR is this:

  • [ ] BugFix
  • [ ] Feature
  • [x] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [x] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 4.0
    • [ ] 3.5
    • [ ] 3.4
    • [ ] 3.3

[!NOTE] Include the matched blacklist rule index in the blocked SQL error message and adjust unit tests accordingly.

  • Backend:
    • Pass blacklist rule id to ErrorReport.reportAnalysisException in SqlBlackList.verifying.
    • Update ErrorCode.ERR_SQL_IN_BLACKLIST_ERROR message to include rule index: Access denied; This sql is in blacklist[Index %s]....
  • Tests:
    • Relax assertions in QueryPlannerTest to check error message contains "Access denied; This sql is in blacklist".
    • Add SqlBlacklistTest.testVerifyingSQLExistsInBlackList to assert verifying throws AnalysisException.
    • Minor imports added for new assertions.

Written by Cursor Bugbot for commit 0f3b554743011394cf719390243352649448db16. This will update automatically on new commits. Configure here.

zhaohehuhu avatar Dec 11 '25 07:12 zhaohehuhu

πŸ§ͺ CI Insights

Here's what we observed from your CI run for 0f3b5547.

🟒 All jobs passed!

But CI Insights is watching πŸ‘€

mergify[bot] avatar Dec 11 '25 07:12 mergify[bot]

@kevincai plz help review

zhaohehuhu avatar Dec 11 '25 08:12 zhaohehuhu

@cursor review

alvin-celerdata avatar Dec 11 '25 15:12 alvin-celerdata

[Java-Extensions Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Dec 15 '25 05:12 github-actions[bot]

[FE Incremental Coverage Report]

:x: fail : 0 / 1 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/meta/SqlBlackList.java 0 1 00.00% [67]

github-actions[bot] avatar Dec 15 '25 05:12 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Dec 15 '25 05:12 github-actions[bot]

@Mergifyio backport branch-4.0

github-actions[bot] avatar Dec 15 '25 07:12 github-actions[bot]

backport branch-4.0

βœ… Backports have been created

mergify[bot] avatar Dec 15 '25 07:12 mergify[bot]