[BugFix] trigger statistics collection on UPDATE statement
Why I'm doing:
Currently, only INSERT and INSERT_OVERWRITE operations trigger statistics collection in specific cases. However, the UPDATE statement can also significantly modify data, such as UPDATE t1 SET c1 = xxxx. In such cases, the statistics should also be updated to accurately reflect these data changes.
What I'm doing:
Make the UPDATE trigger the statistics collection.
TODO:
- support DELETE as well
- change the background statistics collection healthy calculation
Fixes #issue
What type of PR is this:
- [x] BugFix
- [ ] Feature
- [ ] Enhancement
- [ ] Refactor
- [ ] UT
- [ ] Doc
- [ ] Tool
Does this PR entail a change in behavior?
- [ ] Yes, this PR will result in a change in behavior.
- [x] No, this PR will not result in a change in behavior.
If yes, please specify the type of change:
- [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
- [ ] Parameter changes: default values, similar parameters but with different default values
- [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
- [ ] Feature removed
- [ ] Miscellaneous: upgrade & downgrade compatibility, etc.
Checklist:
- [ ] I have added test cases for my bug fix or my new feature
- [ ] This pr needs user documentation (for new or modified features or behaviors)
- [ ] I have added documentation for my new feature or new function
- [ ] This is a backport pr
Bugfix cherry-pick branch check:
- [x] I have checked the version labels which the pr will be auto-backported to the target branch
- [x] 4.0
- [x] 3.5
- [ ] 3.4
- [ ] 3.3
[!NOTE] Enables statistics collection for UPDATE by passing DML type into first-load triggers and updating partition/analyze logic; adds unit and SQL tests.
- Statistics collection:
- Pass
DmlTypethroughLoadJobStatsListenerandStatisticUtils.triggerCollectionOnFirstLoad(...)toStatisticsCollectionTrigger.- Update
StatisticsCollectionTrigger.triggerOnFirstLoad(...)to acceptdmlTypeand handle:
UPDATE: collect on touched partitions regardless of version; record tablet row counts.INSERT_INTO: collect only on first-load partitions (unchanged behavior).- Log for unsupported types (e.g., DELETE) without triggering.
- Preserve analyze type decision; clear tablet row counts unless sampling.
- Tests:
- Add UT
triggerOnUpdateand adapt existing tests to new signatures.- Add SQL tests
test_update_trigger_statisticsverifying FULL/SAMPLE analyze behavior after UPDATEs.Written by Cursor Bugbot for commit dc64a100e556ddb2544ef046e826253a6d9fa04e. This will update automatically on new commits. Configure here.
๐งช CI Insights
Here's what we observed from your CI run for 5bf682f4.
๐ข All jobs passed!
But CI Insights is watching ๐
@cursor review
@cursor review
Quality Gate passed
Issues
2 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
[Java-Extensions Incremental Coverage Report]
:white_check_mark: pass : 0 / 0 (0%)
[FE Incremental Coverage Report]
:white_check_mark: pass : 24 / 29 (82.76%)
file detail
| path | covered_line | new_line | coverage | not_covered_line_detail | |
|---|---|---|---|---|---|
| :large_blue_circle: | com/starrocks/statistic/StatisticUtils.java | 1 | 3 | 33.33% | [165, 166] |
| :large_blue_circle: | com/starrocks/statistic/StatisticsCollectionTrigger.java | 21 | 24 | 87.50% | [305, 311, 315] |
| :large_blue_circle: | com/starrocks/listener/LoadJobStatsListener.java | 2 | 2 | 100.00% | [] |
[BE Incremental Coverage Report]
:white_check_mark: pass : 0 / 0 (0%)
@Mergifyio backport branch-4.0
@Mergifyio backport branch-3.5
backport branch-4.0
โ Backports have been created
- #66780 [BugFix] trigger statistics collection on UPDATE statement (backport #66443) has been created for branch
branch-4.0
backport branch-3.5
โ Backports have been created
- #66779 [BugFix] trigger statistics collection on UPDATE statement (backport #66443) has been created for branch
branch-3.5