[BugFix] cascading cancel the analyze task
Why I'm doing:
What I'm doing:
When analyze statement is cancelled, the background task should also be cancelled.
Fixes #issue
What type of PR is this:
- [x] BugFix
- [ ] Feature
- [ ] Enhancement
- [ ] Refactor
- [ ] UT
- [ ] Doc
- [ ] Tool
Does this PR entail a change in behavior?
- [ ] Yes, this PR will result in a change in behavior.
- [x] No, this PR will not result in a change in behavior.
If yes, please specify the type of change:
- [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
- [ ] Parameter changes: default values, similar parameters but with different default values
- [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
- [ ] Feature removed
- [ ] Miscellaneous: upgrade & downgrade compatibility, etc.
Checklist:
- [ ] I have added test cases for my bug fix or my new feature
- [ ] This pr needs user documentation (for new or modified features or behaviors)
- [ ] I have added documentation for my new feature or new function
- [ ] This is a backport pr
Bugfix cherry-pick branch check:
- [x] I have checked the version labels which the pr will be auto-backported to the target branch
- [x] 4.0
- [x] 3.5
- [ ] 3.4
- [ ] 3.3
[!NOTE] Ensures sync ANALYZE cascades cancellation to its background task and adds a null check before setting
executionId; adds a unit test verifying cancellation.
- Analyze execution/cancellation:
- Use a
CancelableAnalyzeTaskreference outsidetryand, infinally, restore timeouts and callcancel(true)for syncANALYZEif the task hasn’t finished.- Execution ID setup:
- Add null guard when deriving
executionIdfromqueryId(skip ifuuid == null).- Tests:
- Add
testCancelAnalyzeDuringExecutioninStatisticsExecutorTestto mock a long-running analyze and verify the task is cancelled upon interruption.Written by Cursor Bugbot for commit 1aabe23afb7093f3bd1472d0ce849d15526a95d1. This will update automatically on new commits. Configure here.
🧪 CI Insights
Here's what we observed from your CI run for 1aabe23a.
🟢 All jobs passed!
But CI Insights is watching 👀
@cursor review
@cursor review
[FE Incremental Coverage Report]
:white_check_mark: pass : 5 / 5 (100.00%)
file detail
| path | covered_line | new_line | coverage | not_covered_line_detail | |
|---|---|---|---|---|---|
| :large_blue_circle: | com/starrocks/qe/StmtExecutor.java | 5 | 5 | 100.00% | [] |
@mergifyio rebase
rebase
✅ Branch has been successfully rebased
@cursor review
Quality Gate passed
Issues
4 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
[Java-Extensions Incremental Coverage Report]
:white_check_mark: pass : 0 / 0 (0%)
[BE Incremental Coverage Report]
:white_check_mark: pass : 0 / 0 (0%)
@cursor review