starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Enhancement] Abort transaction with failed tablets when retrying broker load job

Open wyb opened this issue 6 months ago • 4 comments

Why I'm doing:

In broker load job plan, replicas or backends that failed in the previous write attempt will be avoided as primary replicas to improve load reliability. The last write failure information are updated when the previous transaction is aborted, using the failed tablets.

What I'm doing:

Update the last write failure information when retrying broker load job.

Fixes #issue

What type of PR is this:

  • [ ] BugFix
  • [ ] Feature
  • [x] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [x] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.5
    • [x] 3.4
    • [ ] 3.3

wyb avatar Jun 19 '25 11:06 wyb

[Java-Extensions Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Jun 23 '25 14:06 github-actions[bot]

[FE Incremental Coverage Report]

:white_check_mark: pass : 23 / 26 (88.46%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/load/loadv2/LoadLoadingTask.java 0 2 00.00% [298, 299]
:large_blue_circle: com/starrocks/load/loadv2/BulkLoadJob.java 16 17 94.12% [243]
:large_blue_circle: com/starrocks/load/loadv2/BrokerLoadingTaskAttachment.java 2 2 100.00% []
:large_blue_circle: com/starrocks/load/loadv2/BrokerLoadJob.java 3 3 100.00% []
:large_blue_circle: com/starrocks/load/loadv2/LoadTask.java 2 2 100.00% []

github-actions[bot] avatar Jun 23 '25 14:06 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Jun 23 '25 14:06 github-actions[bot]

https://github.com/Mergifyio backport branch-3.5

wyb avatar Jun 25 '25 03:06 wyb

backport branch-3.5

✅ Backports have been created

mergify[bot] avatar Jun 25 '25 03:06 mergify[bot]