starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[BugFix] LakeRollup should use physical partition ID instead of partition ID.

Open sevev opened this issue 6 months ago • 5 comments

Why I'm doing:

In shared-data mode, the allocation of shardGroup and shard should correspond to the physical partition ID, rather than the partition ID.

What I'm doing:

Fixes #issue

What type of PR is this:

  • [x] BugFix
  • [ ] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [x] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.5
    • [x] 3.4
    • [ ] 3.3

sevev avatar Jun 19 '25 08:06 sevev

Add some UT?

I will add some test case.

sevev avatar Jun 19 '25 12:06 sevev

[Java-Extensions Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Jun 24 '25 11:06 github-actions[bot]

[FE Incremental Coverage Report]

:white_check_mark: pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/alter/LakeTableRollupBuilder.java 4 4 100.00% []

github-actions[bot] avatar Jun 24 '25 11:06 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Jun 24 '25 11:06 github-actions[bot]

@Mergifyio backport branch-3.5

github-actions[bot] avatar Jun 25 '25 05:06 github-actions[bot]

@Mergifyio backport branch-3.4

github-actions[bot] avatar Jun 25 '25 05:06 github-actions[bot]

backport branch-3.5

✅ Backports have been created

mergify[bot] avatar Jun 25 '25 05:06 mergify[bot]

backport branch-3.4

✅ Backports have been created

mergify[bot] avatar Jun 25 '25 05:06 mergify[bot]