starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Feature] Introduce Column Hash Predicate for rowset data filtering

Open srlch opened this issue 6 months ago • 6 comments

What I'm doing:

This is a prerequisite for tablet splitting. We introduce ColumnHashModulusPredicate into RowsetMetadataPB to provide ability to filter data in all segments of the rowset using this predicate. The predicate calculate the available row for a given chunk in the following way:

  1. Find columns by hash_column_names in chunk and calculate their combined crc32 value.
  2. select[i] = (hashes[i] % modulus == remainder)

Fixes #59134

What type of PR is this:

  • [ ] BugFix
  • [x] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [x] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [ ] 3.5
    • [ ] 3.4
    • [ ] 3.3

srlch avatar Jun 17 '25 08:06 srlch

does it support using a hidden generated column to save the hash value ?

xiangguangyxg avatar Jun 17 '25 09:06 xiangguangyxg

does it support using a hidden generated column to save the hash value ?

I think this predicate can support it as long as we give the correct col_name of the generated column, we can skip the hash value calculation and just using the column itself.

srlch avatar Jun 17 '25 09:06 srlch

[Java-Extensions Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Jun 27 '25 10:06 github-actions[bot]

[FE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Jun 27 '25 10:06 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 79 / 95 (83.16%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: be/src/storage/record_predicate/record_predicate_helper.cpp 40 56 71.43% [34, 35, 36, 37, 75, 76, 77, 78, 79, 80, 82, 94, 95, 96, 97, 98]
:large_blue_circle: be/src/storage/record_predicate/column_hash_is_congruent.h 2 2 100.00% []
:large_blue_circle: be/src/storage/record_predicate/record_predicate.h 3 3 100.00% []
:large_blue_circle: be/src/storage/record_predicate/column_hash_is_congruent.cpp 34 34 100.00% []

github-actions[bot] avatar Jun 27 '25 11:06 github-actions[bot]