[BugFix] Let submitted tasks without execution can be awared in starrocks::LakeServiceImpl to set a correct response and status
Why I'm doing:
Currently, some task submitted by starrocks::LakeServiceImpl can not aware whether the task is executed or not, which will cause the response or status to be set incorrectly.
What I'm doing:
Introduce a Status member for AutoCleanRunnable. This st will be set to OK if it is executed. Let the cleaner accept this internal status to set response correctly.
Fixes #issue
What type of PR is this:
- [x] BugFix
- [ ] Feature
- [ ] Enhancement
- [ ] Refactor
- [ ] UT
- [ ] Doc
- [ ] Tool
Does this PR entail a change in behavior?
- [ ] Yes, this PR will result in a change in behavior.
- [x] No, this PR will not result in a change in behavior.
If yes, please specify the type of change:
- [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
- [ ] Parameter changes: default values, similar parameters but with different default values
- [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
- [ ] Feature removed
- [ ] Miscellaneous: upgrade & downgrade compatibility, etc.
Checklist:
- [x] I have added test cases for my bug fix or my new feature
- [ ] This pr needs user documentation (for new or modified features or behaviors)
- [ ] I have added documentation for my new feature or new function
- [ ] This is a backport pr
Bugfix cherry-pick branch check:
- [x] I have checked the version labels which the pr will be auto-backported to the target branch
- [x] 3.5
- [x] 3.4
- [x] 3.3
[Java-Extensions Incremental Coverage Report]
:white_check_mark: pass : 0 / 0 (0%)
[FE Incremental Coverage Report]
:white_check_mark: pass : 0 / 0 (0%)
[BE Incremental Coverage Report]
:x: fail : 145 / 199 (72.86%)
file detail
| path | covered_line | new_line | coverage | not_covered_line_detail | |
|---|---|---|---|---|---|
| :large_blue_circle: | be/src/exec/write_combined_txn_log.cpp | 9 | 16 | 56.25% | [68, 69, 70, 77, 78, 83, 85] |
| :large_blue_circle: | be/src/util/threadpool.h | 3 | 5 | 60.00% | [71, 90] |
| :large_blue_circle: | be/src/runtime/load_channel_mgr.cpp | 2 | 3 | 66.67% | [64] |
| :large_blue_circle: | be/src/service/service_be/lake_service.cpp | 104 | 145 | 71.72% | [359, 360, 361, 362, 368, 483, 654, 703, 853, 924, 963, 965, 972, 973, 974, 975, 976, 977, 982, 1001, 1003, 1010, 1011, 1012, 1013, 1014, 1015, 1020, 1089, 1090, 1091, 1092, 1098, 1277, 1278, 1279, 1280, 1281, 1282, 1283, 1284] |
| :large_blue_circle: | be/src/util/threadpool.cpp | 27 | 30 | 90.00% | [725, 726, 727] |
@Mergifyio backport branch-3.3
@Mergifyio backport branch-3.4
@Mergifyio backport branch-3.5
backport branch-3.3
✅ Backports have been created
- #60557 [BugFix] Let submitted tasks without execution can be awared in starrocks::LakeServiceImpl to set a correct response and status (backport #59814) has been created for branch
branch-3.3but encountered conflicts
backport branch-3.4
✅ Backports have been created
- #60558 [BugFix] Let submitted tasks without execution can be awared in starrocks::LakeServiceImpl to set a correct response and status (backport #59814) has been created for branch
branch-3.4but encountered conflicts
backport branch-3.5
✅ Backports have been created
- #60556 [BugFix] Let submitted tasks without execution can be awared in starrocks::LakeServiceImpl to set a correct response and status (backport #59814) has been created for branch
branch-3.5but encountered conflicts