starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Enhancement] Introduce version-based vacuum control for cluster snapshot

Open srlch opened this issue 7 months ago • 4 comments

Why I'm doing:

For the vaccum of cluster snapshot, we retain all version large than latest version of the current cluster snapshot createTime But the problem is that too many version can not be vaccumed even the files does not contained in the snapshot version.

What I'm doing:

Introduce version-based vacuum control for cluster snapshot. We get the snapshot version from cluster snapshot and control vaccum as following:

  1. Can not vacuum all retain versions.
  2. Can not vacuum all files ref by the retain versions tablet meta.
  3. The snapshot version are returned by checkpoint worker

Fixes #issue

What type of PR is this:

  • [ ] BugFix
  • [ ] Feature
  • [x] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [x] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [ ] 3.5
    • [ ] 3.4
    • [ ] 3.3
    • [ ] 3.2
    • [ ] 3.1

srlch avatar May 13 '25 03:05 srlch

I think there is useless to record segment files and del files when call TabletRetainInfo::init.

luohaha avatar Jun 25 '25 12:06 luohaha

I think there is useless to record segment files and del files when call TabletRetainInfo::init.

Fixed

srlch avatar Jun 26 '25 02:06 srlch

[Java-Extensions Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Jun 26 '25 04:06 github-actions[bot]

[FE Incremental Coverage Report]

:white_check_mark: pass : 35 / 43 (81.40%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/catalog/CatalogRecycleBin.java 7 10 70.00% [353, 369, 391]
:large_blue_circle: com/starrocks/lake/StarMgrMetaSyncer.java 22 27 81.48% [174, 175, 179, 180, 181]
:large_blue_circle: com/starrocks/lake/snapshot/ClusterSnapshotMgr.java 5 5 100.00% []
:large_blue_circle: com/starrocks/lake/vacuum/AutovacuumDaemon.java 1 1 100.00% []

github-actions[bot] avatar Jun 26 '25 04:06 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 13 / 14 (92.86%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: be/src/storage/lake/vacuum.cpp 12 13 92.31% [577]
:large_blue_circle: be/src/storage/lake/tablet_retain_info.cpp 1 1 100.00% []

github-actions[bot] avatar Jun 26 '25 04:06 github-actions[bot]