starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[BugFix] Fix prepare stmt name out of range in MySQL protocol

Open yangrong688 opened this issue 9 months ago • 8 comments

Why I'm doing:

Try to fix prepare stmt name out of range in MySQL protocol

What I'm doing:

Fixes #56440

What type of PR is this:

  • [x] BugFix
  • [ ] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [ ] 3.4
    • [ ] 3.3
    • [ ] 3.2
    • [ ] 3.1
    • [ ] 3.0

yangrong688 avatar Mar 01 '25 15:03 yangrong688

@yangrong688 Do you want to follow this PR?

alvin-celerdata avatar Jun 06 '25 21:06 alvin-celerdata

@yangrong688 Do you want to follow this PR?

Sorry for the late reply, I add a unit test through the help with cursor, please help to review.

yangrong688 avatar Jun 19 '25 00:06 yangrong688

@mergify rebase

alvin-celerdata avatar Jun 19 '25 06:06 alvin-celerdata

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Jun 19 '25 06:06 mergify[bot]

[FE Incremental Coverage Report]

:white_check_mark: pass : 11 / 11 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/qe/StmtExecutor.java 11 11 100.00% []

github-actions[bot] avatar Jun 29 '25 10:06 github-actions[bot]

[Java-Extensions Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Jun 29 '25 14:06 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Jun 29 '25 14:06 github-actions[bot]

run starrocks_fe_unittest

yangrong688 avatar Jun 30 '25 06:06 yangrong688