starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[BugFix] show create table displays Unicode encoding for default value of the field is entered in Chinese characters

Open rohitrs1983 opened this issue 1 year ago • 5 comments

show create table displays Unicode encoding for default value of the field is entered in Chinese characters

Why I'm doing:

What I'm doing:

Fixes #51995

mysql> show create table test111111; +------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | Table | Create Table | +------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | test111111 | CREATE TABLE test111111 ( test3 varchar(111) NULL DEFAULT "撒" COMMENT "撒", test1 char(10) NULL DEFAULT "撒" COMMENT "撒", test2 varchar(1) NULL DEFAULT "撒" COMMENT "撒", test4 char(1) NULL DEFAULT "撒" COMMENT "撒", test5 tinyint(4) NULL COMMENT "test1", test6 varchar(1) NULL COMMENT "test2" ) ENGINE=OLAP DUPLICATE KEY(test3) DISTRIBUTED BY HASH(test3) PROPERTIES ( "compression" = "LZ4", "fast_schema_evolution" = "true", "replicated_storage" = "true", "replication_num" = "1" ); | +------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ 1 row in set (0.00 sec)

What type of PR is this:

  • [X] BugFix
  • [ ] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [X] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [X] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [X] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.3
    • [x] 3.2
    • [x] 3.1
    • [ ] 3.0
    • [ ] 2.5

rohitrs1983 avatar Oct 16 '24 13:10 rohitrs1983

@kevincai added UT validation. please review.

rohitrs1983 avatar Oct 19 '24 05:10 rohitrs1983

[Java-Extensions Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Oct 19 '24 07:10 github-actions[bot]

[FE Incremental Coverage Report]

:white_check_mark: pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/catalog/Column.java 4 4 100.00% []

github-actions[bot] avatar Oct 19 '24 07:10 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Oct 19 '24 07:10 github-actions[bot]

@Mergifyio backport branch-3.3

github-actions[bot] avatar Oct 28 '24 06:10 github-actions[bot]

@Mergifyio backport branch-3.2

github-actions[bot] avatar Oct 28 '24 06:10 github-actions[bot]

@Mergifyio backport branch-3.1

github-actions[bot] avatar Oct 28 '24 06:10 github-actions[bot]

backport branch-3.3

✅ Backports have been created

mergify[bot] avatar Oct 28 '24 06:10 mergify[bot]

backport branch-3.2

✅ Backports have been created

mergify[bot] avatar Oct 28 '24 06:10 mergify[bot]

backport branch-3.1

✅ Backports have been created

mergify[bot] avatar Oct 28 '24 06:10 mergify[bot]

Ignore backport to branch-3.1

kevincai avatar Nov 11 '24 03:11 kevincai