starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[BugFix] Fix AstToStringBuilder::visitCastExpr may throw NPE while th…

Open mlbzssk opened this issue 1 year ago • 8 comments

…e targetTypeDef is null (#50964)

Signed-off-by: starry [email protected]

Why I'm doing:

AstToStringBuilder::visitCastExpr may throw NPE while the targetTypeDef is null

What I'm doing:

Fixes #issue50964

What type of PR is this:

  • [x] BugFix
  • [ ] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.3
    • [x] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

mlbzssk avatar Sep 13 '24 02:09 mlbzssk

@Mergifyio rebase main

trueeyu avatar Oct 16 '24 07:10 trueeyu

rebase main

✅ Branch has been successfully rebased

mergify[bot] avatar Oct 16 '24 07:10 mergify[bot]

https://github.com/Mergifyio rebase main

trueeyu avatar Oct 17 '24 02:10 trueeyu

rebase main

✅ Branch has been successfully rebased

mergify[bot] avatar Oct 17 '24 02:10 mergify[bot]

[Java-Extensions Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Oct 17 '24 04:10 github-actions[bot]

[FE Incremental Coverage Report]

:x: fail : 3 / 5 (60.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/sql/analyzer/AstToStringBuilder.java 3 5 60.00% [1016, 1017]

github-actions[bot] avatar Oct 17 '24 04:10 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Oct 17 '24 04:10 github-actions[bot]

it's solved by https://github.com/StarRocks/starrocks/pull/56306.

mlbzssk avatar Mar 31 '25 03:03 mlbzssk