starrocks
starrocks copied to clipboard
[BugFix] The update_config interface still returns success after the dynamic parameter setup fails.
Why I'm doing:
What I'm doing:
Fixes #50822
What type of PR is this:
- [x] BugFix
- [ ] Feature
- [ ] Enhancement
- [ ] Refactor
- [ ] UT
- [ ] Doc
- [ ] Tool
Does this PR entail a change in behavior?
- [x] Yes, this PR will result in a change in behavior.
- [ ] No, this PR will not result in a change in behavior.
If yes, please specify the type of change:
- [x] Interface/UI changes: syntax, type conversion, expression evaluation, display information
- [ ] Parameter changes: default values, similar parameters but with different default values
- [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
- [ ] Feature removed
- [ ] Miscellaneous: upgrade & downgrade compatibility, etc.
Checklist:
- [x] I have added test cases for my bug fix or my new feature
- [ ] This pr needs user documentation (for new or modified features or behaviors)
- [ ] I have added documentation for my new feature or new function
- [ ] This is a backport pr
Bugfix cherry-pick branch check:
- [x] I have checked the version labels which the pr will be auto-backported to the target branch
- [x] 3.3
- [x] 3.2
- [x] 3.1
- [ ] 3.0
- [ ] 2.5
[Java-Extensions Incremental Coverage Report]
:white_check_mark: pass : 0 / 0 (0%)
[FE Incremental Coverage Report]
:white_check_mark: pass : 0 / 0 (0%)
[BE Incremental Coverage Report]
:x: fail : 56 / 115 (48.70%)
file detail
| path | covered_line | new_line | coverage | not_covered_line_detail | |
|---|---|---|---|---|---|
| :large_blue_circle: | be/src/http/action/update_config_action.cpp | 41 | 98 | 41.84% | [85, 91, 101, 113, 115, 123, 125, 126, 130, 131, 132, 134, 139, 141, 143, 145, 146, 148, 151, 157, 164, 166, 169, 172, 175, 179, 182, 186, 191, 192, 197, 202, 207, 211, 216, 223, 227, 232, 236, 237, 240, 241, 244, 245, 253, 257, 264, 269, 273, 277, 297, 303, 310, 347, 348, 349, 351] |
| :large_blue_circle: | be/src/common/configbase.cpp | 15 | 17 | 88.24% | [257, 261] |
@Mergifyio backport branch-3.3
@Mergifyio backport branch-3.2
backport branch-3.3
✅ Backports have been created
- #52661 [BugFix] The update_config interface still returns success after the dynamic parameter setup fails. (backport #50821) has been created for branch
branch-3.3
backport branch-3.2
✅ Backports have been created
- #52662 [BugFix] The update_config interface still returns success after the dynamic parameter setup fails. (backport #50821) has been created for branch
branch-3.2but encountered conflicts