starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[BugFix]: make be thrift server socket keep-alive

Open Jin-H opened this issue 1 year ago • 3 comments

Why I'm doing:

Fix BE node thrift connection could not release.

What I'm doing:

Fixes https://github.com/StarRocks/starrocks/issues/50423

when keepalive enabled, we can see all connection timer is open which depends kernel conf f0fdbe5b280ce70cf6289f5ede51a45

What type of PR is this:

  • [x] BugFix
  • [ ] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [x] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.3
    • [x] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

Jin-H avatar Aug 29 '24 10:08 Jin-H

@Mergifyio rebase main

trueeyu avatar Sep 03 '24 01:09 trueeyu

rebase main

✅ Branch has been successfully rebased

mergify[bot] avatar Sep 03 '24 01:09 mergify[bot]

[Java-Extensions Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Sep 03 '24 03:09 github-actions[bot]

[FE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Sep 03 '24 03:09 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: be/src/util/thrift_server.cpp 1 1 100.00% []

github-actions[bot] avatar Sep 03 '24 03:09 github-actions[bot]

@Mergifyio backport branch-3.3

github-actions[bot] avatar Sep 03 '24 05:09 github-actions[bot]

@Mergifyio backport branch-3.2

github-actions[bot] avatar Sep 03 '24 05:09 github-actions[bot]

@Mergifyio backport branch-3.1

github-actions[bot] avatar Sep 03 '24 06:09 github-actions[bot]

backport branch-3.3

✅ Backports have been created

mergify[bot] avatar Sep 03 '24 06:09 mergify[bot]

backport branch-3.2

✅ Backports have been created

mergify[bot] avatar Sep 03 '24 06:09 mergify[bot]

backport branch-3.1

✅ Backports have been created

mergify[bot] avatar Sep 03 '24 06:09 mergify[bot]