starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Enhancement] improve statistics strategy for insert overwrite

Open murphyatwork opened this issue 1 year ago • 3 comments

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • [ ] BugFix
  • [ ] Feature
  • [x] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.3
    • [ ] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

murphyatwork avatar Aug 29 '24 08:08 murphyatwork

@Mergifyio rebase

murphyatwork avatar Sep 24 '24 23:09 murphyatwork

rebase

❌ Unable to rebase: user murphyatwork is unknown.

Please make sure murphyatwork has logged in Mergify dashboard.

mergify[bot] avatar Sep 24 '24 23:09 mergify[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar Oct 08 '24 09:10 sonarqubecloud[bot]

[Java-Extensions Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Oct 08 '24 11:10 github-actions[bot]

[FE Incremental Coverage Report]

:white_check_mark: pass : 226 / 244 (92.62%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/sql/optimizer/statistics/StatisticStorage.java 1 2 50.00% [48]
:large_blue_circle: com/starrocks/statistic/StatisticsCollectionTrigger.java 134 149 89.93% [132, 157, 158, 159, 197, 198, 199, 211, 212, 220, 227, 228, 229, 230, 293]
:large_blue_circle: com/starrocks/listener/LoadJobStatsListener.java 12 13 92.31% [74]
:large_blue_circle: com/starrocks/qe/DmlType.java 14 15 93.33% [45]
:large_blue_circle: com/starrocks/catalog/OlapTable.java 1 1 100.00% []
:large_blue_circle: com/starrocks/common/Config.java 1 1 100.00% []
:large_blue_circle: com/starrocks/transaction/InsertOverwriteJobStats.java 20 20 100.00% []
:large_blue_circle: com/starrocks/statistic/StatisticExecutor.java 7 7 100.00% []
:large_blue_circle: com/starrocks/statistic/StatisticUtils.java 3 3 100.00% []
:large_blue_circle: com/starrocks/qe/StmtExecutor.java 4 4 100.00% []
:large_blue_circle: com/starrocks/load/InsertOverwriteJobRunner.java 14 14 100.00% []
:large_blue_circle: com/starrocks/statistic/FullStatisticsCollectJob.java 12 12 100.00% []
:large_blue_circle: com/starrocks/listener/GlobalLoadJobListenerBus.java 2 2 100.00% []
:large_blue_circle: com/starrocks/transaction/TableCommitInfo.java 1 1 100.00% []

github-actions[bot] avatar Oct 08 '24 11:10 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Oct 08 '24 11:10 github-actions[bot]

@Mergifyio backport branch-3.3

github-actions[bot] avatar Oct 09 '24 06:10 github-actions[bot]

backport branch-3.3

✅ Backports have been created

mergify[bot] avatar Oct 09 '24 06:10 mergify[bot]

ignore backport check: 3.3.5

wangsimo0 avatar Oct 09 '24 13:10 wangsimo0