starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[BugFix] Fix BDBJE handshake bug

Open gengjun-git opened this issue 1 year ago • 4 comments

Why I'm doing:

What I'm doing:

Upgrade starrocks-bdb-je version to 18.3.19. Change the FEEDER_TIMEOUT same to REPLICA_TIMEOUT. PR #21274 tried to fix the bug by setting different values, but it didn't work.

Fixes #

A replica with the name: xxx is already active with the Feeder:null HANDSHAKE_ERROR: Error during the handshake between two nodes. xxxxxx
        at com.sleepycat.je.rep.stream.ReplicaFeederHandshake.negotiateProtocol(ReplicaFeederHandshake.java:198)
        at com.sleepycat.je.rep.stream.ReplicaFeederHandshake.execute(ReplicaFeederHandshake.java:250)
        at com.sleepycat.je.rep.impl.node.Replica.initReplicaLoop(Replica.java:710)
        at com.sleepycat.je.rep.impl.node.Replica.runReplicaLoopInternal(Replica.java:486)
        at com.sleepycat.je.rep.impl.node.Replica.runReplicaLoop(Replica.java:413)
        at com.sleepycat.je.rep.impl.node.RepNode.run(RepNode.java:1871)

What type of PR is this:

  • [x] BugFix
  • [ ] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.3
    • [ ] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

gengjun-git avatar Aug 29 '24 08:08 gengjun-git

[Java-Extensions Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Aug 29 '24 09:08 github-actions[bot]

[FE Incremental Coverage Report]

:white_check_mark: pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/journal/bdbje/BDBEnvironment.java 1 1 100.00% []

github-actions[bot] avatar Aug 29 '24 09:08 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Aug 29 '24 09:08 github-actions[bot]

@Mergifyio backport branch-3.3

github-actions[bot] avatar Sep 03 '24 06:09 github-actions[bot]

backport branch-3.3

✅ Backports have been created

mergify[bot] avatar Sep 03 '24 06:09 mergify[bot]

https://github.com/Mergifyio backport branch-3.1 branch-3.2

gengjun-git avatar Dec 19 '24 06:12 gengjun-git

backport branch-3.1 branch-3.2

✅ Backports have been created

mergify[bot] avatar Dec 19 '24 06:12 mergify[bot]