[Enhancement] Push down target table schema to files() in insert
Why I'm doing:
files() schema infer is not strict.
for example, integer in csv will be inferred to bigint type.
when the target table column is tinyint, the data may be filtered because it is bigger than tinyint.
but strict mode will not take effect in file scan if using bigint type.
What I'm doing:
push down target table slot ref column to files().
Fixes #issue
What type of PR is this:
- [ ] BugFix
- [ ] Feature
- [x] Enhancement
- [ ] Refactor
- [ ] UT
- [ ] Doc
- [ ] Tool
Does this PR entail a change in behavior?
- [x] Yes, this PR will result in a change in behavior.
- [ ] No, this PR will not result in a change in behavior.
If yes, please specify the type of change:
- [x] Interface/UI changes: syntax, type conversion, expression evaluation, display information
- [ ] Parameter changes: default values, similar parameters but with different default values
- [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
- [ ] Feature removed
- [ ] Miscellaneous: upgrade & downgrade compatibility, etc.
Checklist:
- [x] I have added test cases for my bug fix or my new feature
- [ ] This pr needs user documentation (for new or modified features or behaviors)
- [ ] I have added documentation for my new feature or new function
- [ ] This is a backport pr
Bugfix cherry-pick branch check:
- [x] I have checked the version labels which the pr will be auto-backported to the target branch
- [ ] 3.3
- [ ] 3.2
- [ ] 3.1
- [ ] 3.0
- [ ] 2.5
Quality Gate passed
Issues
14 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
[Java-Extensions Incremental Coverage Report]
:white_check_mark: pass : 0 / 0 (0%)
[BE Incremental Coverage Report]
:white_check_mark: pass : 0 / 0 (0%)
[FE Incremental Coverage Report]
:white_check_mark: pass : 70 / 73 (95.89%)
file detail
| path | covered_line | new_line | coverage | not_covered_line_detail | |
|---|---|---|---|---|---|
| :large_blue_circle: | com/starrocks/sql/analyzer/InsertAnalyzer.java | 59 | 62 | 95.16% | [354, 405, 420] |
| :large_blue_circle: | com/starrocks/common/Config.java | 1 | 1 | 100.00% | [] |
| :large_blue_circle: | com/starrocks/sql/analyzer/QueryAnalyzer.java | 3 | 3 | 100.00% | [] |
| :large_blue_circle: | com/starrocks/catalog/TableFunctionTable.java | 4 | 4 | 100.00% | [] |
| :large_blue_circle: | com/starrocks/sql/ast/FileTableFunctionRelation.java | 3 | 3 | 100.00% | [] |