starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Enhancement] improve partial update by column mode overflow estimate strategy

Open luohaha opened this issue 5 months ago • 3 comments

Why I'm doing:

In previous PR #49054, I introduced partial_update_memory_limit_per_worker to prevent ArrayColumn object overflow (larger than 4GB), but still some issue remain. Because I use the avg column data size to estimate how large ArrayColumn object can be, and it will still overflow when multi columns were updated and one of them is much larger than others.

What I'm doing:

Using whole rows in upt file to estimate how large ArrayColumn object instead of using the avg column data size. It may lead to overvalue but it's still better than undervalue which will lead to overflow.

What type of PR is this:

  • [ ] BugFix
  • [ ] Feature
  • [x] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [x] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.3
    • [x] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

luohaha avatar Aug 27 '24 03:08 luohaha