starrocks
starrocks copied to clipboard
[BugFix] Fix ast to sql exception when writing audit log
Why I'm doing:
select from files needs file schema to generate sql from ast.
If BE is down, the schema will be null, and an exception will be thrown when writing audit log.
What I'm doing:
add a new function AstToSQLBuilder.toSQLOrDefault to return sql from ast or default sql if builder throws exception.
Fixes https://github.com/StarRocks/StarRocksTest/issues/7954 #46893
What type of PR is this:
- [x] BugFix
- [ ] Feature
- [ ] Enhancement
- [ ] Refactor
- [ ] UT
- [ ] Doc
- [ ] Tool
Does this PR entail a change in behavior?
- [ ] Yes, this PR will result in a change in behavior.
- [x] No, this PR will not result in a change in behavior.
If yes, please specify the type of change:
- [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
- [ ] Parameter changes: default values, similar parameters but with different default values
- [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
- [ ] Feature removed
- [ ] Miscellaneous: upgrade & downgrade compatibility, etc.
Checklist:
- [x] I have added test cases for my bug fix or my new feature
- [ ] This pr needs user documentation (for new or modified features or behaviors)
- [ ] I have added documentation for my new feature or new function
- [ ] This is a backport pr
Bugfix cherry-pick branch check:
- [x] I have checked the version labels which the pr will be auto-backported to the target branch
- [x] 3.3
- [x] 3.2
- [ ] 3.1
- [ ] 3.0
- [ ] 2.5
Quality Gate passed
Issues
5 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
[FE Incremental Coverage Report]
:white_check_mark: pass : 6 / 7 (85.71%)
file detail
| path | covered_line | new_line | coverage | not_covered_line_detail | |
|---|---|---|---|---|---|
| :large_blue_circle: | com/starrocks/qe/StmtExecutor.java | 0 | 1 | 00.00% | [2507] |
| :large_blue_circle: | com/starrocks/sql/analyzer/AstToSQLBuilder.java | 5 | 5 | 100.00% | [] |
| :large_blue_circle: | com/starrocks/qe/ConnectProcessor.java | 1 | 1 | 100.00% | [] |
[BE Incremental Coverage Report]
:white_check_mark: pass : 0 / 0 (0%)
@Mergifyio backport branch-3.3
@Mergifyio backport branch-3.2
backport branch-3.3
✅ Backports have been created
- #47722 [BugFix] Fix ast to sql exception when writing audit log (backport #47700) has been created for branch
branch-3.3but encountered conflicts
backport branch-3.2
✅ Backports have been created
- #47723 [BugFix] Fix ast to sql exception when writing audit log (backport #47700) has been created for branch
branch-3.2but encountered conflicts