starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Feature] Add array function of array_flatten

Open sfwang218 opened this issue 1 year ago • 5 comments

Why I'm doing:

What I'm doing:

Fixes #19819

What type of PR is this:

  • [ ] BugFix
  • [x] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [x] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [x] I have added test cases for my bug fix or my new feature
  • [x] This pr needs user documentation (for new or modified features or behaviors)
    • [x] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [ ] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.3
    • [x] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

sfwang218 avatar Jun 27 '24 09:06 sfwang218

[BE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Jun 27 '24 09:06 github-actions[bot]

Could you add more sql test case about combination of array function, like: array_slice(array_flatten)... array_flatten(array_slice)...

Seaven avatar Jun 27 '24 12:06 Seaven

[FE Incremental Coverage Report]

:x: fail : 0 / 9 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/sql/analyzer/ExpressionAnalyzer.java 0 9 00.00% [1496, 1497, 1499, 1500, 1501, 1502, 1504, 1505, 1506]

github-actions[bot] avatar Jun 27 '24 14:06 github-actions[bot]

Could you add more sql test case about combination of array function, like: array_slice(array_flatten)... array_flatten(array_slice)...

I don't know how to add sql test, could you please provide me with some reference samples?

sfwang218 avatar Jun 28 '24 02:06 sfwang218

Could you add more sql test case about combination of array function, like: array_slice(array_flatten)... array_flatten(array_slice)...

I don't know how to add sql test, could you please provide me with some reference samples?

you can find SQL test sample in merged function pr like this one https://github.com/StarRocks/starrocks/pull/17905

wangsimo0 avatar Jul 24 '24 06:07 wangsimo0

Could you add more sql test case about combination of array function, like: array_slice(array_flatten)... array_flatten(array_slice)...

I don't know how to add sql test, could you please provide me with some reference samples?

you can find SQL test sample in merged function pr like this one #17905

Okay, I will take a look at it, thank you.

sfwang218 avatar Jul 24 '24 06:07 sfwang218

wangsimo0

Could you add more sql test case about combination of array function, like: array_slice(array_flatten)... array_flatten(array_slice)...

I don't know how to add sql test, could you please provide me with some reference samples?

you can find SQL test sample in merged function pr like this one #17905

Could you add more sql test case about combination of array function, like: array_slice(array_flatten)... array_flatten(array_slice)...

I don't know how to add sql test, could you please provide me with some reference samples?

you can find SQL test sample in merged function pr like this one #17905

Hello, I've just opened a new pull request #50080 , and I will close this one. Could you please review it when you have time? Thank you.

sfwang218 avatar Aug 21 '24 08:08 sfwang218