starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Enhancement] Support getting physical partition by name

Open xiangguangyxg opened this issue 1 year ago • 3 comments

Why I'm doing:

Physical partition only has id but no name, replication need get physical partition by name.

What I'm doing:

Support getting physical partition by name

Fixes #issue

What type of PR is this:

  • [ ] BugFix
  • [ ] Feature
  • [x] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.3
    • [x] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

xiangguangyxg avatar Jun 20 '24 06:06 xiangguangyxg

Quality Gate Failed Quality Gate failed

Failed conditions
3.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jul 10 '24 02:07 sonarqubecloud[bot]

[FE Incremental Coverage Report]

:white_check_mark: pass : 54 / 66 (81.82%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/catalog/PhysicalPartitionImpl.java 4 6 66.67% [121, 122]
:large_blue_circle: com/starrocks/catalog/Partition.java 10 14 71.43% [563, 564, 566, 567]
:large_blue_circle: com/starrocks/replication/ReplicationJob.java 3 4 75.00% [619]
:large_blue_circle: com/starrocks/catalog/OlapTable.java 30 35 85.71% [1404, 1409, 1410, 1411, 1413]
:large_blue_circle: com/starrocks/server/LocalMetastore.java 7 7 100.00% []

github-actions[bot] avatar Jul 10 '24 04:07 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Jul 10 '24 04:07 github-actions[bot]

@Mergifyio backport branch-3.3

github-actions[bot] avatar Jul 19 '24 02:07 github-actions[bot]

@Mergifyio backport branch-3.2

github-actions[bot] avatar Jul 19 '24 02:07 github-actions[bot]

backport branch-3.3

✅ Backports have been created

mergify[bot] avatar Jul 19 '24 02:07 mergify[bot]

backport branch-3.2

✅ Backports have been created

mergify[bot] avatar Jul 19 '24 02:07 mergify[bot]