starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Enhancement] Retry apply after apply failed.

Open sevev opened this issue 8 months ago • 2 comments

Why I'm doing:

The tablet will be set to error state if apply fails and the tablet in error state cannot be read or written and can only be recovered by restarting the BE process. However, not all apply failures require setting the tablet to an error state. Some apply failure scenarios can be retried.

BTW, apply failed always return internal error right now and we need to categorize return value in the future.

What I'm doing:

Retry apply if apply failures is tolerable.

Fixes #issue

What type of PR is this:

  • [ ] BugFix
  • [ ] Feature
  • [x] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [x] Yes, this PR will result in a change in behavior.
  • [ ] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [x] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [x] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.3
    • [x] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

sevev avatar Jun 18 '24 06:06 sevev