starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Enhancement] Reduce getAliveComputeNodes call to reduce rpc call

Open kaijianding opened this issue 1 year ago • 4 comments

Why I'm doing:

In shared_data mode, it is very time consuming calling warehouseManager.getAliveComputeNodes() which issues a rpc call inside

What I'm doing:

Reduce warehouseManager.getAliveComputeNodes() call in OlapScanNode

What type of PR is this:

  • [ ] BugFix
  • [ ] Feature
  • [x] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.3
    • [ ] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

kaijianding avatar Jun 12 '24 14:06 kaijianding

is it possible to add some UTs to cover the lines?

kevincai avatar Jun 17 '24 22:06 kevincai

[FE Incremental Coverage Report]

:white_check_mark: pass : 4 / 5 (80.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/planner/OlapScanNode.java 4 5 80.00% [516]

github-actions[bot] avatar Jul 02 '24 04:07 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Jul 02 '24 04:07 github-actions[bot]

@Mergifyio backport branch-3.3

github-actions[bot] avatar Jul 02 '24 12:07 github-actions[bot]

backport branch-3.3

✅ Backports have been created

mergify[bot] avatar Jul 02 '24 12:07 mergify[bot]