starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Refactor] remove some unused intrinsics

Open stdpain opened this issue 1 year ago • 2 comments

in GCC-11.4 all of the code in offsets_copy will be auto-vectorized. so we could remove them

.L4:
        vpaddd  ymm0, ymm1, YMMWORD PTR [rdi+rax]
        vmovdqu YMMWORD PTR [rdx+rax], ymm0
        add     rax, 32
        cmp     rcx, rax
        jne     .L4

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • [ ] BugFix
  • [ ] Feature
  • [ ] Enhancement
  • [x] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [ ] 3.3
    • [ ] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

stdpain avatar May 20 '24 13:05 stdpain

[FE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar May 21 '24 04:05 github-actions[bot]

[BE Incremental Coverage Report]

:x: fail : 3 / 4 (75.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: be/src/exec/arrow_to_starrocks_converter.cpp 2 3 66.67% [382]
:large_blue_circle: be/src/exec/arrow_to_starrocks_converter.h 1 1 100.00% []

github-actions[bot] avatar May 21 '24 04:05 github-actions[bot]