starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Enhancement] Enable shared scan for cloud native data source

Open tracymacding opened this issue 1 year ago • 2 comments

Why I'm doing:

What I'm doing:

The pr wants to address the issue where parallel scans enabled for cloud-native tables but were not effectively taking place. There are two primary reasons for this problem:

  1. The scan_dop was not recorded in DynamicMorselQueue, causing the max_degree_of_parallelism interface to return 1.
  2. LakeDataSourceProvider returns false withinalways_shared_scan, preventing the use of SharedMorselQueueFactory and instead enforcing the use of IndividualMorselQueueFactory. This IndividualMorselQueueFactory would limit the parallelism of the ScanOperator to 1. For more information on SharedMorselQueueFactory and IndividualMorselQueueFactory, please refer to the illustration below.

image

image

Fixes #issue https://github.com/StarRocks/StarRocksTest/issues/7270

What type of PR is this:

  • [ ] BugFix
  • [ ] Feature
  • [x] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [x] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.3
    • [x] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

tracymacding avatar May 14 '24 08:05 tracymacding

rerun

tracymacding avatar May 27 '24 01:05 tracymacding

[FE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Jun 03 '24 06:06 github-actions[bot]

[BE Incremental Coverage Report]

:x: fail : 0 / 7 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: src/connector/lake_connector.cpp 0 7 00.00% [639, 640, 643, 649, 651, 652, 662]

github-actions[bot] avatar Jun 03 '24 06:06 github-actions[bot]

@Mergifyio backport branch-3.3

github-actions[bot] avatar Jun 03 '24 06:06 github-actions[bot]

backport branch-3.3

✅ Backports have been created

mergify[bot] avatar Jun 03 '24 06:06 mergify[bot]