starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Feature] add mann_whitney_u_test aggregate function

Open jixxiong opened this issue 1 year ago • 4 comments

Why I'm doing:

What I'm doing:

feat #45513

What type of PR is this:

  • [ ] BugFix
  • [x] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [x] I have added test cases for my bug fix or my new feature
  • [x] This pr needs user documentation (for new or modified features or behaviors)
    • [x] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [ ] I have checked the version labels which the pr will be auto-backported to the target branch
    • [ ] 3.3
    • [ ] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

jixxiong avatar May 13 '24 01:05 jixxiong

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 13 '24 01:05 CLAassistant

@jixxiong thanks very much for this contribution. Could you create a GitHub issue to track this function, and relate this PR to that issue? And we will discuss this function in that issue ticket, like the background of this function, the behavior, and the limitations etc.

imay avatar May 13 '24 02:05 imay

@jixxiong thanks very much for this contribution. Could you create a GitHub issue to track this function, and relate this PR to that issue? And we will discuss this function in that issue ticket, like the background of this function, the behavior, and the limitations etc.

I'm glad I could help. I have created a GitHub issue to track this function and linked it to this PR. You can find the issue #45513.

jixxiong avatar May 13 '24 02:05 jixxiong

Great Job! Thx for your great job.

LGTM. You may add some docs about using this function later.

Just some little comments.

Thanks for your advise, I have added some docs in the commit @commit dafb0a7d07f53491991595e584136e6216e37ed3.

jixxiong avatar May 20 '24 01:05 jixxiong

@Mergify rebase

andyziye avatar Aug 09 '24 07:08 andyziye

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Aug 09 '24 07:08 mergify[bot]

@mergify rebase

jixxiong avatar Aug 14 '24 12:08 jixxiong

rebase

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • [ ] any of:
    • [ ] sender-permission>=read
    • [ ] sender=github-actions[bot]

mergify[bot] avatar Aug 14 '24 12:08 mergify[bot]

@mergify rebase

jixxiong avatar Aug 14 '24 12:08 jixxiong

rebase

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • [ ] any of:
    • [ ] sender-permission>=read
    • [ ] sender=github-actions[bot]

mergify[bot] avatar Aug 14 '24 12:08 mergify[bot]

@mergify rebase

LiShuMing avatar Aug 23 '24 02:08 LiShuMing

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Aug 23 '24 02:08 mergify[bot]

[Java-Extensions Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Aug 27 '24 09:08 github-actions[bot]

[BE Incremental Coverage Report]

:x: fail : 8 / 280 (02.86%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: be/src/exprs/agg/helpers/serialize_helpers.hpp 0 46 00.00% [36, 38, 39, 43, 45, 46, 50, 51, 55, 56, 73, 74, 75, 76, 77, 82, 83, 84, 85, 86, 87, 89, 151, 152, 153, 155, 158, 159, 160, 172, 173, 174, 175, 181, 182, 183, 184, 233, 237, 242, 243, 245, 250, 251, 253, 255]
:large_blue_circle: be/src/exprs/agg/hypothesis_testing_common.h 0 13 00.00% [34, 35, 37, 38, 39, 40, 41, 42, 43, 44, 48, 55, 57]
:large_blue_circle: be/src/exprs/agg/mann_whitney.h 1 206 00.49% [40, 42, 43, 45, 46, 47, 50, 52, 53, 54, 57, 58, 59, 60, 61, 62, 63, 65, 66, 67, 69, 70, 71, 72, 73, 75, 76, 77, 78, 79, 82, 83, 86, 87, 88, 89, 90, 91, 93, 94, 95, 96, 97, 98, 99, 101, 102, 103, 104, 105, 108, 109, 110, 111, 112, 113, 114, 116, 117, 119, 120, 123, 124, 125, 126, 127, 129, 130, 131, 132, 137, 139, 140, 143, 144, 146, 147, 148, 149, 150, 152, 153, 154, 155, 157, 158, 160, 163, 164, 165, 168, 169, 171, 172, 173, 175, 178, 179, 180, 181, 189, 190, 191, 192, 194, 196, 199, 212, 214, 217, 220, 222, 223, 225, 226, 227, 228, 229, 230, 231, 232, 234, 235, 237, 238, 240, 241, 242, 246, 249, 251, 252, 253, 255, 256, 257, 259, 260, 263, 264, 265, 267, 270, 271, 272, 273, 274, 275, 277, 278, 279, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 293, 294, 295, 296, 298, 299, 300, 301, 302, 304, 306, 307, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 320, 321, 323, 324, 326, 327, 328, 332, 333, 334, 336, 337, 338, 340, 341, 342, 344, 345, 348, 349, 352]
:large_blue_circle: be/src/exprs/function_helper.h 0 8 00.00% [46, 47, 48, 49, 50, 52, 53, 54]
:large_blue_circle: be/src/exprs/agg/factory/aggregate_resolver_hypothesis_testing.cpp 4 4 100.00% []
:large_blue_circle: be/src/exprs/agg/factory/aggregate_factory.hpp 2 2 100.00% []
:large_blue_circle: be/src/exprs/agg/factory/aggregate_factory.cpp 1 1 100.00% []

github-actions[bot] avatar Aug 27 '24 09:08 github-actions[bot]

[FE Incremental Coverage Report]

:white_check_mark: pass : 22 / 23 (95.65%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/sql/analyzer/FunctionAnalyzer.java 14 15 93.33% [540]
:large_blue_circle: com/starrocks/catalog/FunctionSet.java 8 8 100.00% []

github-actions[bot] avatar Aug 27 '24 09:08 github-actions[bot]