starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Refactor] port analyze CreateFunctionStmt to CreateFunctionAnalyzer::analyze

Open stdpain opened this issue 1 year ago • 2 comments

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • [ ] BugFix
  • [ ] Feature
  • [ ] Enhancement
  • [x] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [ ] I have checked the version labels which the pr will be auto-backported to the target branch
    • [ ] 3.3
    • [ ] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

stdpain avatar May 11 '24 13:05 stdpain

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar May 14 '24 03:05 sonarqubecloud[bot]

[FE Incremental Coverage Report]

:x: fail : 228 / 299 (76.25%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/analysis/FunctionName.java 0 4 00.00% [105, 109, 115, 121]
:large_blue_circle: com/starrocks/sql/analyzer/CreateFunctionAnalyzer.java 218 285 76.49% [72, 86, 87, 95, 96, 103, 109, 111, 112, 113, 115, 116, 117, 119, 120, 122, 124, 125, 127, 128, 129, 133, 140, 160, 161, 163, 164, 166, 167, 221, 222, 223, 296, 297, 383, 388, 389, 391, 399, 427, 428, 429, 438, 439, 446, 447, 448, 451, 452, 453, 467, 468, 469, 470, 476, 477, 478, 492, 493, 494, 499, 500, 501, 504, 505, 506, 507]
:large_blue_circle: com/starrocks/sql/analyzer/Analyzer.java 1 1 100.00% []
:large_blue_circle: com/starrocks/sql/ast/CreateFunctionStmt.java 9 9 100.00% []

github-actions[bot] avatar May 14 '24 04:05 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar May 14 '24 04:05 github-actions[bot]