starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[BugFix] Fix duplicated error rows in load tracking log

Open wyb opened this issue 1 year ago • 2 comments

Why I'm doing:

CREATE TABLE `t3` (
  `k1` bigint NOT NULL,
  `k2` bigint NOT NULL,
  `k3` bigint NOT NULL
)

insert into t3 values (null, null, null);

mysql> select tracking_log from information_schema.load_tracking_logs where job_id=284223;
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| tracking_log                                                                                                                                                                                                 |
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Error: NULL value in non-nullable column 'k1'. Row: [NULL, NULL, NULL]
Error: NULL value in non-nullable column 'k2'. Row: [0, NULL, NULL]
Error: NULL value in non-nullable column 'k3'. Row: [0, 0, NULL]
 |
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.05 sec)

there are 3 rows in tracking logs and the last 2 rows is wrong.

What I'm doing:

mysql> select tracking_log from information_schema.load_tracking_logs where job_id=284327;
+-------------------------------------------------------------------------+
| tracking_log                                                            |
+-------------------------------------------------------------------------+
| Error: NULL value in non-nullable column 'k1'. Row: [NULL, NULL, NULL]
 |
+-------------------------------------------------------------------------+
1 row in set (0.02 sec)

only record the first invalid column k1 for the inserted row.

Fixes #issue

What type of PR is this:

  • [x] BugFix
  • [ ] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.3
    • [x] 3.2
    • [x] 3.1
    • [ ] 3.0
    • [ ] 2.5

wyb avatar May 11 '24 11:05 wyb

[FE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar May 13 '24 07:05 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: be/src/exec/tablet_sink.cpp 1 1 100.00% []

github-actions[bot] avatar May 13 '24 07:05 github-actions[bot]

@Mergifyio backport branch-3.3

github-actions[bot] avatar May 16 '24 06:05 github-actions[bot]

@Mergifyio backport branch-3.2

github-actions[bot] avatar May 16 '24 06:05 github-actions[bot]

@Mergifyio backport branch-3.1

github-actions[bot] avatar May 16 '24 06:05 github-actions[bot]

backport branch-3.3

✅ Backports have been created

mergify[bot] avatar May 16 '24 06:05 mergify[bot]

backport branch-3.2

✅ Backports have been created

mergify[bot] avatar May 16 '24 06:05 mergify[bot]

backport branch-3.1

✅ Backports have been created

mergify[bot] avatar May 16 '24 06:05 mergify[bot]