starrocks
starrocks copied to clipboard
[Refactor] Refactor create table analyzer process
Why I'm doing:
What I'm doing:
No logic modification, just tidying up the code logic
Fixes #issue
fix https://github.com/StarRocks/starrocks/issues/44543
What type of PR is this:
- [ ] BugFix
- [ ] Feature
- [ ] Enhancement
- [x] Refactor
- [ ] UT
- [ ] Doc
- [ ] Tool
Does this PR entail a change in behavior?
- [ ] Yes, this PR will result in a change in behavior.
- [x] No, this PR will not result in a change in behavior.
If yes, please specify the type of change:
- [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
- [ ] Parameter changes: default values, similar parameters but with different default values
- [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
- [ ] Feature removed
- [ ] Miscellaneous: upgrade & downgrade compatibility, etc.
Checklist:
- [ ] I have added test cases for my bug fix or my new feature
- [ ] This pr needs user documentation (for new or modified features or behaviors)
- [ ] I have added documentation for my new feature or new function
- [ ] This is a backport pr
Bugfix cherry-pick branch check:
- [x] I have checked the version labels which the pr will be auto-backported to the target branch
- [ ] 3.3
- [ ] 3.2
- [ ] 3.1
- [ ] 3.0
- [ ] 2.5
Quality Gate passed
Issues
16 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
[FE Incremental Coverage Report]
:white_check_mark: pass : 389 / 448 (86.83%)
file detail
| path | covered_line | new_line | coverage | not_covered_line_detail | |
|---|---|---|---|---|---|
| :large_blue_circle: | com/starrocks/connector/elasticsearch/EsUtil.java | 0 | 6 | 00.00% | [66, 67, 70, 71, 78, 79] |
| :large_blue_circle: | com/starrocks/sql/common/MetaUtils.java | 0 | 2 | 00.00% | [57, 60] |
| :large_blue_circle: | com/starrocks/sql/ast/KeysDesc.java | 10 | 16 | 62.50% | [30, 31, 32, 33, 34, 60] |
| :large_blue_circle: | com/starrocks/sql/ast/CreateTableStmt.java | 14 | 20 | 70.00% | [308, 309, 312, 316, 317, 320] |
| :large_blue_circle: | com/starrocks/sql/analyzer/CreateTableAnalyzer.java | 268 | 301 | 89.04% | [92, 117, 128, 148, 149, 186, 192, 231, 240, 245, 267, 268, 291, 306, 319, 324, 328, 338, 344, 371, 372, 410, 416, 426, 435, 448, 478, 486, 487, 527, 533, 534, 551] |
| :large_blue_circle: | com/starrocks/sql/ast/IndexDef.java | 90 | 96 | 93.75% | [79, 125, 139, 169, 181, 211] |
| :large_blue_circle: | com/starrocks/sql/analyzer/InsertAnalyzer.java | 2 | 2 | 100.00% | [] |
| :large_blue_circle: | com/starrocks/sql/analyzer/DropStmtAnalyzer.java | 3 | 3 | 100.00% | [] |
| :large_blue_circle: | com/starrocks/sql/analyzer/AlterTableClauseVisitor.java | 1 | 1 | 100.00% | [] |
| :large_blue_circle: | com/starrocks/sql/analyzer/CreateDbAnalyzer.java | 1 | 1 | 100.00% | [] |
[BE Incremental Coverage Report]
:white_check_mark: pass : 0 / 0 (0%)
@Mergifyio backport branch-3.3
backport branch-3.3
✅ Backports have been created
- #48679 [Refactor] Refactor create table analyzer process (backport #45498) has been created for branch
branch-3.3but encountered conflicts