starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Enhancement] The logic of the output column is split into two stages.

Open trueeyu opened this issue 1 year ago • 2 comments

Why I'm doing:

This is the second pr of lazy materialize join.

In the past, there was only one stage of join output column, but now it is split into two stages, output predicate columns and lazy output of other columns.

What I'm doing:

  • The logic of the output column is split into two stages.
  • Remove row_desc, it's useless.
  • Add param enable_lazy_materialize for join hash table.

What type of PR is this:

  • [ ] BugFix
  • [ ] Feature
  • [x] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.3
    • [ ] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

trueeyu avatar May 11 '24 04:05 trueeyu

[FE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar May 11 '24 08:05 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 99 / 100 (99.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: be/src/exec/hash_join_node.cpp 3 4 75.00% [200]
:large_blue_circle: be/src/exec/hash_joiner.h 2 2 100.00% []
:large_blue_circle: be/src/exec/mor_processor.cpp 5 5 100.00% []
:large_blue_circle: be/src/exec/join_hash_map.cpp 89 89 100.00% []

github-actions[bot] avatar May 11 '24 08:05 github-actions[bot]

@Mergifyio backport branch-3.3

github-actions[bot] avatar May 13 '24 01:05 github-actions[bot]

backport branch-3.3

✅ Backports have been created

mergify[bot] avatar May 13 '24 01:05 mergify[bot]