starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[BugFix] fix cloud table compaction task concurrency issue

Open starrocks-xupeng opened this issue 9 months ago • 2 comments

Why I'm doing:

fix https://github.com/StarRocks/starrocks/issues/43786

What I'm doing:

  1. when get from queue, check queue idx again in case it's invalid after compaction thread decreases
  2. when put into queue, make it atomic

What type of PR is this:

  • [x] BugFix
  • [ ] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.3
    • [x] 3.2
    • [x] 3.1
    • [ ] 3.0
    • [ ] 2.5

starrocks-xupeng avatar May 08 '24 08:05 starrocks-xupeng

[FE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar May 10 '24 11:05 github-actions[bot]

[BE Incremental Coverage Report]

:x: fail : 13 / 20 (65.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: be/src/storage/lake/compaction_scheduler.h 8 13 61.54% [281, 293, 308, 326, 329]
:large_blue_circle: be/src/storage/lake/compaction_scheduler.cpp 5 7 71.43% [331, 387]

github-actions[bot] avatar May 10 '24 11:05 github-actions[bot]

@Mergifyio backport branch-3.3

github-actions[bot] avatar May 13 '24 06:05 github-actions[bot]

@Mergifyio backport branch-3.2

github-actions[bot] avatar May 13 '24 06:05 github-actions[bot]

@Mergifyio backport branch-3.1

github-actions[bot] avatar May 13 '24 06:05 github-actions[bot]

backport branch-3.3

✅ Backports have been created

mergify[bot] avatar May 13 '24 06:05 mergify[bot]

backport branch-3.2

✅ Backports have been created

mergify[bot] avatar May 13 '24 06:05 mergify[bot]

backport branch-3.1

✅ Backports have been created

mergify[bot] avatar May 13 '24 06:05 mergify[bot]

https://github.com/StarRocks/starrocks/pull/45525 branch-3.1

starrocks-xupeng avatar May 13 '24 07:05 starrocks-xupeng

https://github.com/StarRocks/starrocks/pull/45529 branch-3.2

starrocks-xupeng avatar May 13 '24 07:05 starrocks-xupeng

https://github.com/StarRocks/starrocks/pull/45530 branch-3.3

starrocks-xupeng avatar May 13 '24 07:05 starrocks-xupeng