starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[BugFix] fix incorrect date/datetime mysql binary packet

Open packy92 opened this issue 9 months ago • 2 comments

Why I'm doing:

fix #45072 https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_binary_resultset.html date/datetime binary resultset is malformed.

What I'm doing:

according to the standard to return the correct packet.

Fixes #issue

What type of PR is this:

  • [x] BugFix
  • [ ] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [x] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.3
    • [x] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

packy92 avatar May 07 '24 15:05 packy92

[FE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar May 09 '24 07:05 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 56 / 70 (80.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: be/src/column/adaptive_nullable_column.cpp 0 2 00.00% [304, 306]
:large_blue_circle: be/src/column/const_column.h 0 3 00.00% [206, 207, 208]
:large_blue_circle: be/src/runtime/mysql_result_writer.cpp 3 6 50.00% [145, 146, 148]
:large_blue_circle: be/src/util/mysql_row_buffer.cpp 37 43 86.05% [253, 254, 255, 256, 257, 258]
:large_blue_circle: be/src/column/array_column.cpp 1 1 100.00% []
:large_blue_circle: be/src/column/object_column.cpp 1 1 100.00% []
:large_blue_circle: be/src/column/struct_column.cpp 1 1 100.00% []
:large_blue_circle: be/src/column/map_column.cpp 1 1 100.00% []
:large_blue_circle: be/src/column/decimalv3_column.cpp 1 1 100.00% []
:large_blue_circle: be/src/column/nullable_column.cpp 4 4 100.00% []
:large_blue_circle: be/src/column/json_column.cpp 1 1 100.00% []
:large_blue_circle: be/src/column/binary_column.cpp 1 1 100.00% []
:large_blue_circle: be/src/util/mysql_row_buffer.h 1 1 100.00% []
:large_blue_circle: be/src/column/fixed_length_column_base.cpp 4 4 100.00% []

github-actions[bot] avatar May 09 '24 07:05 github-actions[bot]

@Mergifyio backport branch-3.3

github-actions[bot] avatar May 09 '24 09:05 github-actions[bot]

@Mergifyio backport branch-3.2

github-actions[bot] avatar May 09 '24 09:05 github-actions[bot]

backport branch-3.3

✅ Backports have been created

mergify[bot] avatar May 09 '24 09:05 mergify[bot]

backport branch-3.2

✅ Backports have been created

mergify[bot] avatar May 09 '24 09:05 mergify[bot]