starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Enhancement] Fix serveral cache select use problems

Open Smith-Cruise opened this issue 9 months ago • 3 comments

Why I'm doing:

What I'm doing:

  • Replace ALREADY_CACHED_SIZE to READ_CACHE_SIZE, ALREADY_CACHED_SIZE is ambiguity.
  • Show verbose msg if people submit task cache select xxx from tbl("verbose"="true")
  • Show error msg when some querys counter exception in submit task.
  • remove STATUS column, it's useless, because it's always show SUCCESS.

What type of PR is this:

  • [ ] BugFix
  • [ ] Feature
  • [x] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [x] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.3
    • [ ] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

Smith-Cruise avatar May 07 '24 09:05 Smith-Cruise

[BE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar May 07 '24 11:05 github-actions[bot]

[FE Incremental Coverage Report]

:white_check_mark: pass : 42 / 44 (95.45%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/qe/DDLStmtExecutor.java 2 3 66.67% [1072]
:large_blue_circle: com/starrocks/datacache/DataCacheSelectMetrics.java 31 32 96.88% [160]
:large_blue_circle: com/starrocks/scheduler/DataCacheSelectProcessor.java 3 3 100.00% []
:large_blue_circle: com/starrocks/datacache/DataCacheSelectExecutor.java 6 6 100.00% []

github-actions[bot] avatar May 07 '24 11:05 github-actions[bot]

@Mergifyio backport branch-3.3

github-actions[bot] avatar May 13 '24 03:05 github-actions[bot]

backport branch-3.3

✅ Backports have been created

mergify[bot] avatar May 13 '24 03:05 mergify[bot]