starrocks
starrocks copied to clipboard
[Enhancement] Log cancel pipeline only once
Why I'm doing:
Decrease log of begin to cancel operators
.
Some operators will take lots of time to cancel, which causes PipelineDriver::cancel_operators
is called multiple times when it is expired.
What I'm doing:
Only log begin to cancel operators
once for a pipeline driver.
What type of PR is this:
- [ ] BugFix
- [ ] Feature
- [x] Enhancement
- [ ] Refactor
- [ ] UT
- [ ] Doc
- [ ] Tool
Does this PR entail a change in behavior?
- [ ] Yes, this PR will result in a change in behavior.
- [x] No, this PR will not result in a change in behavior.
If yes, please specify the type of change:
- [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
- [ ] Parameter changes: default values, similar parameters but with different default values
- [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
- [ ] Feature removed
- [ ] Miscellaneous: upgrade & downgrade compatibility, etc.
Checklist:
- [ ] I have added test cases for my bug fix or my new feature
- [ ] This pr needs user documentation (for new or modified features or behaviors)
- [ ] I have added documentation for my new feature or new function
- [ ] This is a backport pr
Bugfix cherry-pick branch check:
- [x] I have checked the version labels which the pr will be auto-backported to the target branch
- [x] 3.3
- [x] 3.2
- [x] 3.1
- [x] 3.0
- [ ] 2.5
[FE Incremental Coverage Report]
:white_check_mark: pass : 0 / 0 (0%)
[BE Incremental Coverage Report]
:white_check_mark: pass : 3 / 3 (100.00%)
file detail
path | covered_line | new_line | coverage | not_covered_line_detail | |
---|---|---|---|---|---|
:large_blue_circle: | be/src/exec/pipeline/pipeline_driver.cpp | 3 | 3 | 100.00% | [] |
@Mergifyio backport branch-3.3
@Mergifyio backport branch-3.2
@Mergifyio backport branch-3.1
@Mergifyio backport branch-3.0
backport branch-3.3
✅ Backports have been created
-
#50449 [Enhancement] Log cancel pipeline only once (backport #45103) has been created for branch
branch-3.3
backport branch-3.2
✅ Backports have been created
-
#50450 [Enhancement] Log cancel pipeline only once (backport #45103) has been created for branch
branch-3.2
but encountered conflicts
backport branch-3.1
✅ Backports have been created
-
#50451 [Enhancement] Log cancel pipeline only once (backport #45103) has been created for branch
branch-3.1
but encountered conflicts
backport branch-3.0
✅ Backports have been created
-
#50452 [Enhancement] Log cancel pipeline only once (backport #45103) has been created for branch
branch-3.0
but encountered conflicts