starrocks
starrocks copied to clipboard
[BugFix] Support BE log sys_log_level modify to take effect dynamically
Why I'm doing:
dynamic update for sys_log_level, sys log level should be updated to the specified log level
What I'm doing:
dynamic update for sys_log_level, sys log level should be updated to the specified log level
Fixes #45062
What type of PR is this:
- [X] BugFix
- [ ] Feature
- [ ] Enhancement
- [ ] Refactor
- [ ] UT
- [ ] Doc
- [ ] Tool
Does this PR entail a change in behavior?
- [x] Yes, this PR will result in a change in behavior.
- [ ] No, this PR will not result in a change in behavior.
If yes, please specify the type of change:
- [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
- [ ] Parameter changes: default values, similar parameters but with different default values
- [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
- [ ] Feature removed
- [X] Miscellaneous: upgrade & downgrade compatibility, etc.
Checklist:
- [ ] I have added test cases for my bug fix or my new feature
- [ ] This pr needs user documentation (for new or modified features or behaviors)
- [ ] I have added documentation for my new feature or new function
- [ ] This is a backport pr
Bugfix cherry-pick branch check:
- [X] I have checked the version labels which the pr will be auto-backported to the target branch
- [X] 3.3
- [X] 3.2
- [X] 3.1
- [ ] 3.0
- [ ] 2.5
@rohitrs1983 thanks for the update, there is a clang-format check failure. please take a look and fix it as necessary.
@rohitrs1983 thanks for the update, there is a clang-format check failure. please take a look and fix it as necessary.
@kevincai fixed the clang-format check.
[FE Incremental Coverage Report]
:white_check_mark: pass : 0 / 0 (0%)
[BE Incremental Coverage Report]
:x: fail : 2 / 13 (15.38%)
file detail
| path | covered_line | new_line | coverage | not_covered_line_detail | |
|---|---|---|---|---|---|
| :large_blue_circle: | be/src/common/logconfig.cpp | 1 | 12 | 08.33% | [254, 255, 256, 257, 258, 259, 260, 261, 262, 264, 266] |
| :large_blue_circle: | be/src/http/action/update_config_action.cpp | 1 | 1 | 100.00% | [] |
@imay PTAL and check if you can skip the coverage check.
@imay PTAL and check if you can skip the coverage check.
@imay can u please merge this
@Mergifyio backport branch-3.3
@Mergifyio backport branch-3.2
@Mergifyio backport branch-3.1
backport branch-3.3
✅ Backports have been created
- #45461 [BugFix] Support BE log sys_log_level modify to take effect dynamically (backport #45063) has been created for branch
branch-3.3
backport branch-3.2
✅ Backports have been created
- #45462 [BugFix] Support BE log sys_log_level modify to take effect dynamically (backport #45063) has been created for branch
branch-3.2
backport branch-3.1
✅ Backports have been created
- #45463 [BugFix] Support BE log sys_log_level modify to take effect dynamically (backport #45063) has been created for branch
branch-3.1