starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Enhancement] Support log query profile to file

Open before-Sunrise opened this issue 1 year ago • 3 comments

Why I'm doing:

https://github.com/StarRocks/starrocks/pull/43652 wants to log query profile to file, but is a wrong implementation.

What I'm doing:

This pr move the profile log logical into profile upload task. And if profile upload is in async mode, it will report profile even if not all instance report finish after profileTimeout.

so if profile upload is in sync mode, query thread will execute profile upload task at end of query procession. if profile upload is in async mode, it will put 'profile upload task' into profile-worker threadPool when all instance report finish status or not all instance report finish status after profileTimeout, profile-worker will execute profile upload task for async profile.

profile log only used when Config.enable_collect_query_detail_info && Config.enable_profile_log

Fixes #issue

What type of PR is this:

  • [ ] BugFix
  • [ ] Feature
  • [x] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
  • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.3
    • [x] 3.2
    • [x] 3.1
    • [ ] 3.0
    • [ ] 2.5

before-Sunrise avatar Apr 30 '24 07:04 before-Sunrise

Quality Gate Failed Quality Gate failed

Failed conditions
17.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 09 '24 11:05 sonarqubecloud[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar May 09 '24 13:05 github-actions[bot]

[FE Incremental Coverage Report]

:x: fail : 4 / 14 (28.57%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/qe/StmtExecutor.java 2 12 16.67% [914, 915, 916, 919, 920, 921, 922, 923, 924, 926]
:large_blue_circle: com/starrocks/common/Config.java 1 1 100.00% []
:large_blue_circle: com/starrocks/qe/DefaultCoordinator.java 1 1 100.00% []

github-actions[bot] avatar May 09 '24 13:05 github-actions[bot]

@Mergifyio backport branch-3.3

github-actions[bot] avatar May 13 '24 12:05 github-actions[bot]

@Mergifyio backport branch-3.2

github-actions[bot] avatar May 13 '24 12:05 github-actions[bot]

@Mergifyio backport branch-3.1

github-actions[bot] avatar May 13 '24 12:05 github-actions[bot]

backport branch-3.3

✅ Backports have been created

mergify[bot] avatar May 13 '24 12:05 mergify[bot]

backport branch-3.2

✅ Backports have been created

mergify[bot] avatar May 13 '24 12:05 mergify[bot]

backport branch-3.1

✅ Backports have been created

mergify[bot] avatar May 13 '24 12:05 mergify[bot]