starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[BugFix] Multi bytes CSV row/column delimiter for `files()`

Open rickif opened this issue 1 year ago • 3 comments

Why I'm doing:

What I'm doing:

This PR corrects the CSV format multi bytes delimiter for files() Fixes https://github.com/StarRocks/StarRocksTest/issues/7268

What type of PR is this:

  • [x] BugFix
  • [ ] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.3
    • [ ] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

rickif avatar Apr 30 '24 03:04 rickif

[FE Incremental Coverage Report]

:white_check_mark: pass : 20 / 24 (83.33%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/planner/StreamLoadScanNode.java 2 6 33.33% [204, 205, 218, 219]
:large_blue_circle: com/starrocks/planner/FileScanNode.java 6 6 100.00% []
:large_blue_circle: com/starrocks/common/ErrorReport.java 1 1 100.00% []
:large_blue_circle: com/starrocks/common/ErrorCode.java 1 1 100.00% []
:large_blue_circle: com/starrocks/catalog/TableFunctionTable.java 10 10 100.00% []

github-actions[bot] avatar May 10 '24 08:05 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar May 10 '24 08:05 github-actions[bot]

@Mergifyio backport branch-3.3

github-actions[bot] avatar May 10 '24 09:05 github-actions[bot]

backport branch-3.3

✅ Backports have been created

mergify[bot] avatar May 10 '24 09:05 mergify[bot]

@Mergifyio backport branch-3.2

rickif avatar May 10 '24 09:05 rickif

backport branch-3.2

✅ Backports have been created

mergify[bot] avatar May 10 '24 09:05 mergify[bot]