starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[BugFix] Fix AgentTask not finished when node as compute node

Open smartlxh opened this issue 1 year ago • 3 comments

Why I'm doing:

FE will always wait for task to be finished, for report_task_worker won't work when node as compute node if task timeout in be.

What I'm doing:

Enable report_task_worker_pool and task should be reported to FE even if timeout. Fixes #issue

What type of PR is this:

  • [x] BugFix
  • [ ] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [x] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.3
    • [x] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

smartlxh avatar Apr 23 '24 09:04 smartlxh

[FE Incremental Coverage Report]

:white_check_mark: pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/leader/ReportHandler.java 1 1 100.00% []

github-actions[bot] avatar May 07 '24 14:05 github-actions[bot]

[BE Incremental Coverage Report]

:x: fail : 3 / 15 (20.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: be/src/agent/agent_task.cpp 1 13 07.69% [280, 281, 282, 295, 296, 297, 298, 299, 300, 301, 302, 304]
:large_blue_circle: be/src/agent/agent_server.cpp 2 2 100.00% []

github-actions[bot] avatar May 07 '24 14:05 github-actions[bot]

@Mergifyio backport branch-3.3

github-actions[bot] avatar May 08 '24 02:05 github-actions[bot]

@Mergifyio backport branch-3.2

github-actions[bot] avatar May 08 '24 02:05 github-actions[bot]

backport branch-3.3

✅ Backports have been created

mergify[bot] avatar May 08 '24 02:05 mergify[bot]

backport branch-3.2

✅ Backports have been created

mergify[bot] avatar May 08 '24 02:05 mergify[bot]