starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[BugFix] Fix bug which cause LakePersistentIndex will recover all the rowsets

Open TszKitLo40 opened this issue 3 months ago • 2 comments

Why I'm doing:

If LakePersistentIndex is recovered once and sstables are created in insert, the created sstable's version will be 0. If LakePersistentIndex is recovered again, it will needd to recover all the rowsets.

What I'm doing:

  1. Maintain max_version in memtable
  2. Set max_version in the sstable to be flushed
  3. Add more trace in recover to help us know the time cost

Fixes #issue

What type of PR is this:

  • [x] BugFix
  • [ ] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [x] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.3
    • [ ] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

TszKitLo40 avatar Apr 22 '24 01:04 TszKitLo40