starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Enhancement] Improve insert column mismatch error message

Open wyb opened this issue 1 year ago • 3 comments

Why I'm doing:

t1 has 3 columns.

mysql> insert into t1 values (1,1,1,1);
ERROR 1064 (HY000): Getting analyzing error. Detail message: Column count doesn't match value count.

mysql> insert into t1 (k1,k2) select * from t1;
ERROR 1064 (HY000): Getting analyzing error. Detail message: Column count doesn't match value count.

What I'm doing:

mysql> insert into t1 values (1,1,1,1);
ERROR 5604 (42000): Getting analyzing error. Detail message: Inserted target column count: 3 doesn't match select/value column count: 4.

mysql> insert into t1 (k1,k2) select * from t1;
ERROR 5604 (42000): Getting analyzing error. Detail message: Inserted target column count: 2 doesn't match select/value column count: 3.

Fixes #issue

What type of PR is this:

  • [ ] BugFix
  • [ ] Feature
  • [x] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [x] Yes, this PR will result in a change in behavior.
  • [ ] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [x] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [x] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.3
    • [x] 3.2
    • [x] 3.1
    • [ ] 3.0
    • [ ] 2.5

wyb avatar Apr 18 '24 07:04 wyb

[BE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Apr 30 '24 10:04 github-actions[bot]

[FE Incremental Coverage Report]

:white_check_mark: pass : 3 / 3 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/sql/analyzer/InsertAnalyzer.java 2 2 100.00% []
:large_blue_circle: com/starrocks/common/ErrorCode.java 1 1 100.00% []

github-actions[bot] avatar Apr 30 '24 10:04 github-actions[bot]

@Mergifyio backport branch-3.3

github-actions[bot] avatar May 07 '24 03:05 github-actions[bot]

@Mergifyio backport branch-3.2

github-actions[bot] avatar May 07 '24 03:05 github-actions[bot]

@Mergifyio backport branch-3.1

github-actions[bot] avatar May 07 '24 03:05 github-actions[bot]

backport branch-3.3

✅ Backports have been created

mergify[bot] avatar May 07 '24 03:05 mergify[bot]

backport branch-3.2

✅ Backports have been created

mergify[bot] avatar May 07 '24 03:05 mergify[bot]

backport branch-3.1

✅ Backports have been created

mergify[bot] avatar May 07 '24 03:05 mergify[bot]