[Enhancement] frontend RPC error message
Why I'm doing:
When there's a FE RPC failure, we often get a error call frontend service failed reason=xxx.
What I'm doing:
This PR improves the error message.
| error type | old error message | new error message |
|---|---|---|
| RPC timeout | call frontend service failed, address=TNetworkAddress(hostname=127.0.0.1, port=19020), reason=THRIFT_EAGAIN (timed out) | FE RPC failure, address=TNetworkAddress(hostname=127.0.0.1, port=19020), reason=THRIFT_EAGAIN (timed out) |
| RPC response parsing failure | call frontend service failed, address=TNetworkAddress(hostname=127.0.0.1, port=19020), reason=Invalid TType | FE RPC response parsing failure, address=TNetworkAddress(hostname=127.0.0.1, port=19020), reason=THRIFT_EAGAIN (timed out). |
| other | call frontend service failed, ddress=TNetworkAddress(hostname=127.0.0.1, port=19020), reason=xxx | FE RPC failure, address=TNetworkAddress(hostname=127.0.0.1, port=19020), reason=xxx |
Fixes #issue
What type of PR is this:
- [ ] BugFix
- [ ] Feature
- [x] Enhancement
- [ ] Refactor
- [ ] UT
- [ ] Doc
- [ ] Tool
Does this PR entail a change in behavior?
- [ ] Yes, this PR will result in a change in behavior.
- [x] No, this PR will not result in a change in behavior.
If yes, please specify the type of change:
- [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
- [ ] Parameter changes: default values, similar parameters but with different default values
- [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
- [ ] Feature removed
- [ ] Miscellaneous: upgrade & downgrade compatibility, etc.
Checklist:
- [x] I have added test cases for my bug fix or my new feature
- [ ] This pr needs user documentation (for new or modified features or behaviors)
- [ ] I have added documentation for my new feature or new function
- [ ] This is a backport pr
Bugfix cherry-pick branch check:
- [x] I have checked the version labels which the pr will be auto-backported to the target branch
- [x] 3.3
- [x] 3.2
- [ ] 3.1
- [ ] 3.0
- [ ] 2.5
[FE Incremental Coverage Report]
:white_check_mark: pass : 0 / 0 (0%)
[BE Incremental Coverage Report]
:white_check_mark: pass : 32 / 39 (82.05%)
file detail
| path | covered_line | new_line | coverage | not_covered_line_detail | |
|---|---|---|---|---|---|
| :large_blue_circle: | be/src/util/thrift_rpc_helper.cpp | 32 | 39 | 82.05% | [105, 130, 131, 133, 134, 135, 136] |
@Mergifyio backport branch-3.3
@Mergifyio backport branch-3.2
@Mergifyio backport branch-3.1
backport branch-3.3
✅ Backports have been created
- #45169 [Enhancement] frontend RPC error message (backport #44153) has been created for branch
branch-3.3
backport branch-3.2
✅ Backports have been created
- #45171 [Enhancement] frontend RPC error message (backport #44153) has been created for branch
branch-3.2but encountered conflicts
backport branch-3.1
✅ Backports have been created
- #45170 [Enhancement] frontend RPC error message (backport #44153) has been created for branch
branch-3.1but encountered conflicts