starrocks
starrocks copied to clipboard
[Enhancement] support dynamic runtime filter wait time
Why I'm doing:
What I'm doing:
- modify runtime filter wait time by scan bytes * selectivity, wait least scan io cost time
- modify runtime filter generagte strategy, to check the selectivity of left table. before this pr, the runtime filter would always be generated, only use selectivity to decide which node to use runtimefilter
Fixes #issue
What type of PR is this:
- [ ] BugFix
- [ ] Feature
- [x] Enhancement
- [ ] Refactor
- [ ] UT
- [ ] Doc
- [ ] Tool
Does this PR entail a change in behavior?
- [ ] Yes, this PR will result in a change in behavior.
- [x] No, this PR will not result in a change in behavior.
If yes, please specify the type of change:
- [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
- [ ] Parameter changes: default values, similar parameters but with different default values
- [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
- [ ] Feature removed
- [ ] Miscellaneous: upgrade & downgrade compatibility, etc.
Checklist:
- [x] I have added test cases for my bug fix or my new feature
- [ ] This pr needs user documentation (for new or modified features or behaviors)
- [ ] I have added documentation for my new feature or new function
- [ ] This is a backport pr
Bugfix cherry-pick branch check:
- [x] I have checked the version labels which the pr will be auto-backported to the target branch
- [ ] 3.2
- [ ] 3.1
- [ ] 3.0
- [ ] 2.5
[FE Incremental Coverage Report]
:white_check_mark: pass : 45 / 51 (88.24%)
file detail
path | covered_line | new_line | coverage | not_covered_line_detail | |
---|---|---|---|---|---|
:large_blue_circle: | com/starrocks/sql/optimizer/statistics/StatisticsEstimateCoefficient.java | 0 | 1 | 00.00% | [18] |
:large_blue_circle: | com/starrocks/qe/SessionVariable.java | 2 | 4 | 50.00% | [1333, 1334] |
:large_blue_circle: | com/starrocks/planner/ScanNode.java | 14 | 17 | 82.35% | [121, 122, 125] |
:large_blue_circle: | com/starrocks/planner/RuntimeFilterDescription.java | 9 | 9 | 100.00% | [] |
:large_blue_circle: | com/starrocks/planner/JoinNode.java | 17 | 17 | 100.00% | [] |
:large_blue_circle: | com/starrocks/planner/NestLoopJoinNode.java | 3 | 3 | 100.00% | [] |
Quality Gate passed
Issues
2 New issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
[BE Incremental Coverage Report]
:x: fail : 4 / 8 (50.00%)
file detail
path | covered_line | new_line | coverage | not_covered_line_detail | |
---|---|---|---|---|---|
:large_blue_circle: | be/src/exec/exec_node.cpp | 4 | 8 | 50.00% | [177, 185, 187, 188] |