starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Enhancement] Insert `files()` query progress

Open rickif opened this issue 1 year ago • 3 comments

Why I'm doing:

Now, the progress of insert into some_tble select * from files(xxx) is not correct. The progress would always be 99% after the insert begins.

What I'm doing:

This PR corrects the progress of this scenario.

Fixes https://github.com/StarRocks/starrocks/issues/41824

What type of PR is this:

  • [ ] BugFix
  • [ ] Feature
  • [x] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [x] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [ ] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

rickif avatar Feb 28 '24 04:02 rickif

[FE Incremental Coverage Report]

:white_check_mark: pass : 19 / 22 (86.36%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/qe/StmtExecutor.java 6 9 66.67% [1957, 1958, 1959]
:large_blue_circle: com/starrocks/planner/FileScanNode.java 3 3 100.00% []
:large_blue_circle: com/starrocks/load/loadv2/LoadMgr.java 3 3 100.00% []
:large_blue_circle: com/starrocks/load/loadv2/InsertLoadJob.java 7 7 100.00% []

github-actions[bot] avatar Feb 28 '24 10:02 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Feb 28 '24 10:02 github-actions[bot]